add deprecation warnings for opentelemetry-exporter-cloud-monitoring and opentelemetry-exporter-cloud-trace #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
final-release-old-exporters-0.10b1
branch
from
ea1206e to
ceda750
Compare
aabmass
force-pushed
the
final-release-old-exporters-0.10b1
branch
from
ceda750 to
61b609d
Compare
ymotongpoo
approved these changes
May 14, 2021
|
Added license headers but the check is still failing 🤷 |
aabmass
merged commit 6fed3eb
into
GoogleCloudPlatform:final-release-old-exporters-0.10b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new orphan branch with the old code (it was in opentelemetry-python upstream repo) final-release-old-exporters-0.10b1. This PR modifies that to warn in code and in the READMEs on pypi that this package is deprecated and what to use instead.
I also bumped the versions to
0.10b1. I'll release these packages once more with just these modifications. You can ignore test failures, this code doesn't have any CI stuff.