Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate trace/metrics packages out for staggered 1.0 release #107

Merged
merged 3 commits into from
Apr 6, 2021

Conversation

aabmass
Copy link
Collaborator

@aabmass aabmass commented Feb 16, 2021

Fixes #119

Because opentelemetry-api 1.0 does not contain metrics, the trace and metrics exporters need to be split so that the trace exporter can be released as stable. The new package names are opentelemetry-exporter-cloud-trace and opentelemetry-exporter-cloud-monitoring (which happen to already exist on PyPI from before I merged them together last year).

I am definitely open to new names, though – please add suggestions. Should they instead be opentelemetry-exporter-google-cloud-{trace,monitoring}? That's pretty long

@google-cla google-cla bot added the cla: yes label Feb 16, 2021
@aabmass aabmass force-pushed the split-packages branch 3 times, most recently from 400096c to b6f43a1 Compare February 19, 2021 20:16
@aabmass aabmass force-pushed the split-packages branch 3 times, most recently from 94548c1 to adf5e6e Compare April 2, 2021 20:04
@aabmass aabmass marked this pull request as ready for review April 5, 2021 21:41
@aabmass aabmass requested a review from a team April 5, 2021 21:41
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that Trace and Monitoring are split into separate modules.

@ymotongpoo ymotongpoo merged commit 249ec10 into GoogleCloudPlatform:master Apr 6, 2021
@aabmass
Copy link
Collaborator Author

aabmass commented Apr 6, 2021

Oops, going to rename to opentelemetry-exporter-gcp-trace and opentelemetry-exporter-gcp-monitoring. Will do in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Homepage" link of opentelemetry-exporter-google-cloud is broken
2 participants