Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource-util): detect GKE and GCE resource attributes #467

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Dec 10, 2022

Implements the resource detection methods for GKE and GCE, copied from https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/tree/v1.8.0/detectors/gcp.

Added a Detector which implements the resource detection interface to glue everything together. I will add the other detectors in separate PRs.

Verified this is working with e2e test in next PR #468

@aabmass aabmass force-pushed the gke-and-gce-detector branch from bf5631c to 3d77fe7 Compare December 10, 2022 03:05
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #467 (0d36f08) into main (bf8edbb) will increase coverage by 0.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   94.93%   95.62%   +0.69%     
==========================================
  Files          13       16       +3     
  Lines         474      549      +75     
  Branches       91      102      +11     
==========================================
+ Hits          450      525      +75     
  Misses         24       24              
Impacted Files Coverage Δ
...entelemetry-resource-util/src/detector/detector.ts 100.00% <100.00%> (ø)
...es/opentelemetry-resource-util/src/detector/gce.ts 100.00% <100.00%> (ø)
...es/opentelemetry-resource-util/src/detector/gke.ts 100.00% <100.00%> (ø)
packages/opentelemetry-resource-util/src/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass force-pushed the gke-and-gce-detector branch from 3d77fe7 to 52c34b8 Compare December 10, 2022 03:28
@aabmass aabmass force-pushed the gke-and-gce-detector branch from 52c34b8 to b4f1592 Compare December 10, 2022 04:04
@aabmass aabmass marked this pull request as ready for review December 10, 2022 04:27
@aabmass aabmass requested a review from a team December 10, 2022 04:27
@aabmass aabmass requested a review from dashpole December 13, 2022 21:12
@aabmass aabmass merged commit 88be17e into GoogleCloudPlatform:main Dec 14, 2022
@aabmass aabmass deleted the gke-and-gce-detector branch December 14, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants