Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import for NoopLogger #230

Closed

Conversation

mike-marcacci
Copy link

It appears that OT removed the NoopLogger export from core:
open-telemetry/opentelemetry-js#1746

This prevents app crashes when a logger is not provided. (Don't have time to file a full issue/etc but figured this might help regardless; sorry!)


Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue/feature before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here>

It appears that OT removed the `NoopLogger` export from `core`:
open-telemetry/opentelemetry-js#1746

This prevents app crashes when a logger is not provided.
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #230 (eb16eee) into master (a044c37) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   95.36%   95.37%   +0.01%     
==========================================
  Files          11       11              
  Lines         345      346       +1     
  Branches       67       67              
==========================================
+ Hits          329      330       +1     
  Misses         16       16              
Impacted Files Coverage Δ
...es/opentelemetry-cloud-trace-exporter/src/trace.ts 96.36% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b37fb...5124268. Read the comment docs.

@aabmass
Copy link
Contributor

aabmass commented Feb 2, 2021

This prevents app crashes when a logger is not provided. (Don't have time to file a full issue/etc but figured this might help regardless; sorry!)

Thanks for the PR! Looks like this change is part of OTel JS 0.15.0 (while this lib is currently at 0.14.0) but the tests are passing :) Can you just update the commit message and PR name to pass the conventional commits check?

@aabmass
Copy link
Contributor

aabmass commented Feb 12, 2021

This change is included in #232

@aabmass aabmass closed this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants