Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving API breaking changes from 0.11.0 to 0.13.1 #63

Merged
merged 4 commits into from
Jan 21, 2021

Conversation

scottsue
Copy link
Contributor

@scottsue scottsue commented Jan 1, 2021

OpenTelemetry has API breaking changes from 0.11.0 onwards. PR for updating Google Trace / Metrics to use OpenTelemetry 0.13.1

@google-cla
Copy link

google-cla bot commented Jan 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@scottsue
Copy link
Contributor Author

scottsue commented Jan 1, 2021 via email

@google-cla
Copy link

google-cla bot commented Jan 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@scottsue
Copy link
Contributor Author

scottsue commented Jan 1, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jan 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jsuereth jsuereth self-requested a review January 5, 2021 23:00
@jsuereth
Copy link
Collaborator

jsuereth commented Jan 5, 2021

change looks good, but I'd like to see passing tests. It looks like TestSpanData also needs a ReadableAttributes update.

@scottsue
Copy link
Contributor Author

scottsue commented Jan 6, 2021

Hi Josh,

Thanks for the quick review, apologies for missing the TestSpanData. Thats been pushed now to change ReadableAttributes . For some reason the tests are now failing due to AutoValue generation that is unrelated to the change. Any potential ideas on this that you could point me to?

@jsuereth
Copy link
Collaborator

jsuereth commented Jan 7, 2021

The AutoValue issue, I think, is because the builder is trying to create a setter for soemthing that has a default implementation.

Specifically, instead of setParentSpanId you want to use the new value setParentSpanContext: https://github.com/open-telemetry/opentelemetry-java/blob/master/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/data/SpanData.java#L56.

I'm still getting caught up on the Java changes, so I'm not sure how to specify an invalid parent span context, but if you need help figuring that out I can do so shortly. Sorry for the delay again :)

@scottsue
Copy link
Contributor Author

Ok I think I've got the TestSpanData in a state where the tests are passing now. I've managed to get the invalid parent span context by calling Span.getInvalid().

@jsuereth
Copy link
Collaborator

Thanks so much for the fixes! Sorry I was afk for a week, had something come up :)

LGTM

@jsuereth jsuereth merged commit f7114c1 into GoogleCloudPlatform:master Jan 21, 2021
@scottsue
Copy link
Contributor Author

Great news. Thanks for the guidance through the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants