-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving API breaking changes from 0.11.0 to 0.13.1 #63
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it!
Regards,
Scott
SCOTT SUE
CHIEF TECHNOLOGY OFFICER
Support Line : +44(0) 2031 371 603 <+44%2020%203137%201603>
Mobile : +852 9611 3969 <9611%203969>
20/F, Tower 535, 535 Jaffe Road, Causeway Bay, Hong Kong
www.celer-tech.com
…On 2 Jan 2021 at 1:16:48 AM, google-cla[bot] ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2FGoogleCloudPlatform%2Fopentelemetry-operations-java%2Fpull%2F63>
for more info*.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIF6RLTGK7MNXBLVY257MXLSXX7QBANCNFSM4VQMY62Q>
.
--
_This message, including any attachments, may include private,
privileged and confidential information and is intended only for the
personal and confidential use of the intended recipient(s). If the reader
of this message is not an intended recipient, you are hereby notified that
any review, use, dissemination, distribution, printing or copying of this
message or its contents is strictly prohibited and may be unlawful. If you
are not an intended recipient or have received this communication in error,
please immediately notify the sender by telephone and/or a reply email and
permanently delete the original message, including any attachments, without
making a copy._
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
change looks good, but I'd like to see passing tests. It looks like |
Hi Josh, Thanks for the quick review, apologies for missing the |
The AutoValue issue, I think, is because the builder is trying to create a setter for soemthing that has a default implementation. Specifically, instead of I'm still getting caught up on the Java changes, so I'm not sure how to specify an invalid parent span context, but if you need help figuring that out I can do so shortly. Sorry for the delay again :) |
Ok I think I've got the |
Thanks so much for the fixes! Sorry I was afk for a week, had something come up :) LGTM |
Great news. Thanks for the guidance through the PR. |
OpenTelemetry has API breaking changes from 0.11.0 onwards. PR for updating Google Trace / Metrics to use OpenTelemetry 0.13.1