Update the collector image used in instrumentation quickstart #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
approved these changes
Aug 23, 2024
|
Tests are broken because of GoogleCloudPlatform/opentelemetry-operations-go#797. I can use a different metric instead but will need to modify the tests a little bit. I'm thinking to rewrite the integration test in Go so we can use the same integration test setup across all the repos |
aabmass
force-pushed
the
upgrade-collector
branch
5 times, most recently
from
ce0e6de to
0bac49a
Compare
aabmass
force-pushed
the
upgrade-collector
branch
3 times, most recently
from
6e8d4e1 to
2721137
Compare
aabmass
commented
Aug 30, 2024
examples/instrumentation-quickstart/integration_test/instrumentation_test.go
Outdated
Show resolved
Hide resolved
examples/instrumentation-quickstart/integration_test/instrumentation_test.go
Outdated
Show resolved
Hide resolved
aabmass
added a commit
to aabmass/opentelemetry-operations-e2e-testing
that referenced
this pull request
Sep 4, 2024
Before I add the docker test code from GoogleCloudPlatform/opentelemetry-operations-java#364 to this repo, I wanted to move the e2e test runner code (which is separate to a subpackage). This makes it more explicit what is used for what and simplifies CI a bit.
aabmass
added a commit
to GoogleCloudPlatform/opentelemetry-operations-e2e-testing
that referenced
this pull request
Sep 4, 2024
Before I add the docker test code from GoogleCloudPlatform/opentelemetry-operations-java#364 to this repo, I wanted to move the e2e test runner code (which is separate to a subpackage). This makes it more explicit what is used for what and simplifies CI a bit.
4 tasks
aabmass
force-pushed
the
upgrade-collector
branch
from
64ddb22 to
8b95be3
Compare
lqiu96
referenced
this pull request
in googleapis/sdk-platform-java
Sep 25, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud.opentelemetry:detector-resources-support](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java) | `0.31.0` -> `0.32.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.google.cloud.opentelemetry:shared-resourcemapping](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java) | `0.31.0` -> `0.32.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.google.cloud.opentelemetry:exporter-metrics](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java) | `0.31.0` -> `0.32.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>GoogleCloudPlatform/opentelemetry-operations-java (com.google.cloud.opentelemetry:detector-resources-support)</summary> ### [`v0.32.0`](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/releases/tag/v0.32.0) [Compare Source](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/compare/v0.31.0...v0.32.0) ##### Release Highlights - Enables detection of Cloud Run Jobs environment in GCP resource detector. ##### What's Changed - Delete unused logback xml from instrumentation quickstart by [@​aabmass](https://redirect.github.com/aabmass) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/333](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/333) - Upgrade to latest nebula-release plugin to fix build by [@​aabmass](https://redirect.github.com/aabmass) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/362](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/362) - Migrate e2e tests Container Registry usage to Artifact Registry by [@​aabmass](https://redirect.github.com/aabmass) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/360](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/360) - Update the collector image used in instrumentation quickstart by [@​aabmass](https://redirect.github.com/aabmass) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/364](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/364) - Rename spring example by [@​psx95](https://redirect.github.com/psx95) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/367](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/367) - Add manually instrumented spring sample by [@​psx95](https://redirect.github.com/psx95) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/368](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/368) - Update metrics example by [@​psx95](https://redirect.github.com/psx95) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/370](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/370) - Fix the sample code shown in README by [@​psx95](https://redirect.github.com/psx95) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/373](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/373) - Support cloud run jobs in resource detection by [@​psx95](https://redirect.github.com/psx95) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/371](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/371) - Remove obsolete TODO comment by [@​psx95](https://redirect.github.com/psx95) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/374](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/374) **Full Changelog**: GoogleCloudPlatform/opentelemetry-operations-java@v0.31.0...v0.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the otelcol image and fixed substitution syntax
${}issueSince the gRPC metrics are no longer available, tests were broken. I chose to rewrite the integration test in Go so we can easily use it in the other 3 samples.