Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always output logging.googleapis.com/trace_sampled as true #332

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Always output logging.googleapis.com/trace_sampled as true #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion examples/instrumentation-quickstart/src/main/resources/log4j2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
<Configuration status="WARN">
<Appenders>
<Console name="Console" target="SYSTEM_OUT">
<!-- TODO(#331): output logging.googleapis.com/trace_sampled as a boolean -->
<!-- TODO(#331): output logging.googleapis.com/trace_sampled based on trace_flags instead
of hardcoding as true -->
<!-- [START opentelemetry_instrumentation_setup_logging] -->
<!-- Format JSON logs for the Cloud Logging agent
https://cloud.google.com/logging/docs/structured-logging#special-payload-fields -->
Expand All @@ -37,6 +38,11 @@
format="JSON"
value='{"$resolver": "mdc", "key": "span_id"}'
/>
<EventTemplateAdditionalField
key="logging.googleapis.com/trace_sampled"
format="JSON"
value="true"
/>
</JsonTemplateLayout>
<!-- [END opentelemetry_instrumentation_setup_logging] -->
</Console>
Expand Down
Loading