Add metrics exporter #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoercai
commented
Sep 1, 2020
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricConfiguration.java
Outdated
Show resolved
Hide resolved
nilebox
reviewed
Sep 2, 2020
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricConfiguration.java
Outdated
Show resolved
Hide resolved
nilebox
reviewed
Sep 7, 2020
| @@ -29,6 +30,7 @@ subprojects { | |||
| google_cloud_core : "com.google.cloud:google-cloud-core:${googleCloudVersion}", | |||
| google_cloud_grpc : "com.google.api.grpc:grpc-google-cloud-trace-v2:${googleCloudVersion}", | |||
| google_cloud_trace : "com.google.cloud:google-cloud-trace:${googleCloudVersion}", | |||
| google_cloud_monitoring : "com.google.cloud:google-cloud-monitoring:${cloudMonitoringVersion}", | |||
There was a problem hiding this comment.
We are using {googleCloudVersion} for both core and trace dependencies above, but not for Cloud Monitoring client? Might be worth checking if we should also use separate versioning for core and tracing?
There was a problem hiding this comment.
Yeah I used a separate version for cloud monitoring because the 1.0.2 version didn't have much and didn't work. I've added a separate cloudTracingVersion for tracing, kept it to 1.0.2 for this PR though.
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricExporter.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
nilebox
reviewed
Sep 7, 2020
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
nilebox
reviewed
Sep 8, 2020
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
| !attributes.get("cloud.provider").getStringValue().equals("gcp")) { | ||
| return null; | ||
| } | ||
| String resourceType = attributes.get("gcp.resource_type").getStringValue(); |
There was a problem hiding this comment.
@james-bebbington @aabmass have we agreed to keep this attribute, or should we switch to semantic conventions?
I would suggest to just remove resource GCP mapping for now from the code, and add it later (we also need to add mapping for all other resource types defined in OpenCensus Go exporter for feature parity).
There was a problem hiding this comment.
To clarify, the question was whether we should infer resource type based on other attributes, like we did in open-telemetry/opentelemetry-collector#1462
aabmass
reviewed
Sep 8, 2020
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
nilebox
reviewed
Sep 8, 2020
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
nilebox
approved these changes
Sep 9, 2020
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricExporter.java
Show resolved
Hide resolved
aabmass
approved these changes
Sep 9, 2020
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricExporter.java
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricExporter.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
exporters/metrics/src/main/java/com.google.cloud.opentelemetry.metric/MetricTranslator.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the metric exporter for Google cloud monitoring.
Unit tests here: zoercai#1
End to end tests (WIP) here: zoercai#2