Make the trace flags optional when parsing x-cloud-trace-context (#350)

GoogleCloudPlatform · Jun 4, 2024 · 7a8dcf4 · 7a8dcf4
1 parent f04d7e9
commit 7a8dcf4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/...rc/main/java/com/google/cloud/opentelemetry/propagators/XCloudTraceContextPropagator.java b/...rc/main/java/com/google/cloud/opentelemetry/propagators/XCloudTraceContextPropagator.java
@@ -42,7 +42,7 @@ public final class XCloudTraceContextPropagator implements TextMapPropagator {
   private static final String FIELD = "x-cloud-trace-context";
   private static final Collection<String> FIELDS = Collections.singletonList(FIELD);
   private static final Pattern VALUE_PATTERN =
-      Pattern.compile("(?<traceid>[0-9a-f]{32})\\/(?<spanid>[\\d]{1,20});o=(?<sampled>\\d+)");
+      Pattern.compile("(?<traceid>[0-9a-f]{32})\\/(?<spanid>[\\d]{1,20})(;o=(?<sampled>\\d+))?");
   private static final Logger LOGGER =
       Logger.getLogger(XCloudTraceContextPropagator.class.getCanonicalName());
 

diff --git a/propagators/gcp/src/test/java/com/google/cloud/opentelemetry/propagators/PropagatorTest.java b/propagators/gcp/src/test/java/com/google/cloud/opentelemetry/propagators/PropagatorTest.java
@@ -93,6 +93,22 @@ public void testExtractNotSampled() {
     Assert.assertEquals(false, span.getSpanContext().getTraceFlags().isSampled());
   }
 
+  @Test
+  public void testExtractWithoutTraceFlags() {
+    Context context = Context.root();
+    Map<String, String> carrier = new HashMap<>();
+    carrier.put("x-cloud-trace-context", "00000000000000000000000000000010/15");
+    TextMapPropagator propagator = new XCloudTraceContextPropagator(false);
+
+    // Now try to extract the value.
+    Context updated = propagator.extract(context, carrier, GETTER);
+    Span span = Span.fromContext(updated);
+    Assert.assertNotNull(span);
+    Assert.assertEquals("00000000000000000000000000000010", span.getSpanContext().getTraceId());
+    Assert.assertEquals("000000000000000f", span.getSpanContext().getSpanId());
+    Assert.assertEquals(false, span.getSpanContext().getTraceFlags().isSampled());
+  }
+
   @Test
   public void testNotInjectOneway() {
     Span span =