Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onGKE to use the cluster location, as name may be registered #907

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 30, 2024

Fixes #906

@atoulme atoulme requested a review from a team as a code owner October 30, 2024 01:43
Copy link

google-cla bot commented Oct 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.66%. Comparing base (4caace7) to head (a314f4b).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
+ Coverage   61.03%   63.66%   +2.62%     
==========================================
  Files          56       57       +1     
  Lines        5903     6066     +163     
==========================================
+ Hits         3603     3862     +259     
+ Misses       2143     2042     -101     
- Partials      157      162       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashpole
Copy link
Contributor

/gcbrun

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs the CLA check to pass

@atoulme
Copy link
Contributor Author

atoulme commented Oct 30, 2024

CLA passes.

@dashpole
Copy link
Contributor

/gcbrun

@dashpole dashpole merged commit 8ed7574 into GoogleCloudPlatform:main Oct 31, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onGKE returns true when a kops-deployed k8s cluster is deployed on GCE.
2 participants