Collect metrics asynchronously #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsure we have a fresh collection every
…that are missing at runtime
quentinmit
force-pushed
the
quentin-dcgm-new-metrics
branch
from
0cc11a1 to
5c3bdd5
Compare
…not supported' errors
igorpeshansky
approved these changes
Sep 10, 2024
| client.logger.Warnf("Unable to query '%s' on '%s'", dcgmName, reason) | ||
| if failedCount == maxWarningsForFailedDeviceMetricQuery { | ||
| if failedCount <= limit { | ||
| client.logger.Warnf("%s", reason) |
There was a problem hiding this comment.
logger.Warnf("%s", reason) is the same as logger.Warn(reason) (https://pkg.go.dev/go.uber.org/zap#SugaredLogger.Warn). But I can fix that after we merge this PR…
| @@ -328,9 +328,11 @@ func (client *dcgmClient) collect() (time.Duration, error) { | |||
| if err := isValidValue(fieldValue); err == errBlankValue { | |||
| // Blank values are expected at startup. | |||
| continue | |||
| } else if err == errNotSupported { | |||
| client.issueWarningForFailedQueryUptoThreshold(dcgmName, 1, fmt.Sprintf("Field '%s' is not supported. Metric '%s' will not be collected", dcgmName, dcgmName)) | |||
There was a problem hiding this comment.
The Metric '%s' will not be collected part is redundant (in the profiling metrics as well). But I can fix that after we merge this PR…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.