-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java mapper #300
Java mapper #300
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
+ Coverage 97.24% 97.29% +0.04%
==========================================
Files 103 106 +3
Lines 4391 4546 +155
==========================================
+ Hits 4270 4423 +153
- Misses 121 123 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment about tags constants, otherwise good job 👌🏼
d1c78b4
to
ff1c59f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but I do have some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now, thanks! 💪
Add Java mapper GitOrigin-RevId: 60d10e8b385f8ec73a6c5734e9f4d6cd49a85016 Change-Id: Ibca5cfe68cb29e456014ddc3a8be779f70788c06
Make sure you have checked all steps below and that above description is correct.
Github issues
issue and references it in commit message.
Tests
Commits
Documentation