Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudbuild.yaml #924

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Update cloudbuild.yaml #924

merged 2 commits into from
Dec 14, 2018

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Nov 19, 2018

As requested by @stew-r

@ace-n ace-n requested a review from fhinkel November 19, 2018 18:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2018
args: ['beta', 'functions', 'deploy', '[YOUR_DEPLOYED_FUNCTION_NAME]', '[YOUR_FUNCTION_TRIGGER]', '--runtime', '[YOUR_RUNTIME]', '--entry-point', '[YOUR_FUNCTION_NAME_IN_CODE]']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is beta required?

@stew-r
Copy link
Contributor

stew-r commented Nov 19, 2018 via email

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if possible without extra beta. Thanks!

@fhinkel
Copy link
Contributor

fhinkel commented Nov 27, 2018

ping @ace-n

@ace-n ace-n merged commit 8f9261a into master Dec 14, 2018
@ace-n ace-n deleted the ace-n-patch-1 branch December 14, 2018 01:44
telpirion pushed a commit that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants