Add Monitoring Tests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the test is failing, says |
jmdobry
force-pushed
the
monitoringtests
branch
from
176b2da
to
c79f6ce
Compare
|
I figured it out. |
jmdobry
force-pushed
the
monitoringtests
branch
from
c79f6ce
to
78bd52d
Compare
sethbergman
pushed a commit
to stackriot/nodejs-docs-samples
that referenced
this pull request
Jun 4, 2017
* First draft of ES6 upgrade * Fix nits * Get tests passing + fix more stuff * Upgrade package.json engine to 4.3.2
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
This was referenced Nov 14, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 18, 2022
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM. New feature: methods with pagination now support async iteration.
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
This is an adaptation of GoogleCloudPlatform/cloud-sql-proxy#1271.
irataxy
pushed a commit
that referenced
this pull request
Jan 14, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: bcoe <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
irataxy
pushed a commit
that referenced
this pull request
Jan 18, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: bcoe <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JustinBeckwith @jonparrott
Unfortunately we have to code freeze these samples until GCP Next is over next week, but feel free to review at your convenience.
Had to refactor the main code a bit, since for my custom metric tests, I generate a new custom metric and write one value for it. I made CustomMetrics a class so I could attach the metric name to its state. Not sure if this the most idiomatic way to do it for this repo so let me know.
The tests aren't going to work until the API no longer requires a whitelist. That might be now or very soon (I'll double check), otherwise we can add your test project as an owner of mine.