Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move description from docs into code sample #630

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Move description from docs into code sample #630

merged 2 commits into from
Jun 4, 2018

Conversation

labtopia
Copy link
Contributor

@labtopia labtopia commented Jun 1, 2018 •
edited by ace-n
Loading

As title.

@labtopia
Move description from docs into code sample
b9c7e6b 
As part of making the GCF docs language-agnostic, we are removing language-specific comments from the text and putting them into the code samples instead as code comments.
@ace-n ace-n self-requested a review June 2, 2018 00:36
@codecov
Copy link

codecov bot commented Jun 4, 2018

Codecov Report

Merging #630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce28093...52151d3. Read the comment docs.

@ace-n ace-n merged commit 7c98f38 into GoogleCloudPlatform:master Jun 4, 2018
@snyk-bot snyk-bot mentioned this pull request Dec 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Sep 6, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2022
Open
@NimJay NimJay mentioned this pull request Nov 10, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 10, 2022
@renovate-bot
fix(deps): update dependency mathjs to v10 (#630)
7d16fcc
NimJay pushed a commit that referenced this pull request Nov 10, 2022
@release-please
chore: release 4.3.2 (#632)
689c0ad 
🤖 I have created a release \*beep\* \*boop\*
---
### [4.3.2](https://www.github.com/googleapis/nodejs-language/compare/v4.3.1...v4.3.2) (2021-11-10)


### Bug Fixes

* **deps:** update dependency mathjs to v10 ([#630](https://www.github.com/googleapis/nodejs-language/issues/630)) ([24a189d](https://www.github.com/googleapis/nodejs-language/commit/24a189d1cd2dc68f772f2530684612b4d6ebc2ec))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay pushed a commit that referenced this pull request Nov 10, 2022
@renovate-bot @NimJay
fix(deps): update dependency mathjs to v10 (#630)
2c6f195
NimJay pushed a commit that referenced this pull request Nov 10, 2022
@release-please @NimJay
chore: release 4.3.2 (#632)
f6d7e59 
🤖 I have created a release \*beep\* \*boop\*
---
### [4.3.2](https://www.github.com/googleapis/nodejs-language/compare/v4.3.1...v4.3.2) (2021-11-10)


### Bug Fixes

* **deps:** update dependency mathjs to v10 ([#630](https://www.github.com/googleapis/nodejs-language/issues/630)) ([24a189d](https://www.github.com/googleapis/nodejs-language/commit/24a189d1cd2dc68f772f2530684612b4d6ebc2ec))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@release-please @gcf-owl-bot
chore(main): release 3.1.1 (#630)
7e381f5 
* chore(main): release 3.1.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@ace-n ace-n mentioned this pull request Nov 11, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@release-please @gcf-owl-bot
chore(main): release 3.1.1 (#630)
4758434 
* chore(main): release 3.1.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@release-please @gcf-owl-bot
chore(main): release 3.1.1 (#630)
66720c3 
* chore(main): release 3.1.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 15, 2022
@release-please @gcf-owl-bot
chore(main): release 3.1.1 (#630)
fb3eed6 
* chore(main): release 3.1.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 15, 2022
@release-please @gcf-owl-bot
chore(main): release 3.1.1 (#630)
e99034d 
* chore(main): release 3.1.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@renovate-bot
fix(deps): update dependency @google-cloud/bigquery to v6 (#630)
5b53913
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@renovate-bot
fix(deps): update dependency @google-cloud/bigquery to v6 (#630)
7d597e4
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@renovate-bot
fix(deps): update dependency @google-cloud/bigquery to v6 (#630)
2e4f083
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@renovate-bot
fix(deps): update dependency @google-cloud/bigquery to v6 (#630)
3600910
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@renovate-bot
fix(deps): update dependency @google-cloud/bigquery to v6 (#630)
cf08b81
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please @gcf-owl-bot
chore(main): release 3.1.1 (#630)
17ece29 
* chore(main): release 3.1.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please @gcf-owl-bot
chore(main): release 3.1.1 (#630)
ea152ee 
* chore(main): release 3.1.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
chore: renamed output dir (#634)
d336dc6 
Fixes #630  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
chore: renamed output dir (#634)
ac37317 
Fixes #630  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
fix(deps): update dependency @google-cloud/bigquery to v6 (#630)
27ff366
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@release-please @gcf-owl-bot @ahrarmonsur
chore(main): release 3.1.1 (#630)
05ca7a7 
* chore(main): release 3.1.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
chore: renamed output dir (#634)
ca41d38 
Fixes #630  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
chore: renamed output dir (#634)
49efc87 
Fixes #630  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
chore: renamed output dir (#634)
444d761 
Fixes #630  🦕
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@munkhuushmgl
test: added an expo back off to prevent RESOURCE_EXHAUSTED exception (#…
fe0e6e0 
…630)

* test: added an expo back off to prevent RESOURCE_EXHAUSTED exception

* modified comment

* changed arrow func-> regular
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@munkhuushmgl
test: added an expo back off to prevent RESOURCE_EXHAUSTED exception (#…
6955122 
…630)

* test: added an expo back off to prevent RESOURCE_EXHAUSTED exception

* modified comment

* changed arrow func-> regular
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 18, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 18, 2022
@munkhuushmgl @NimJay
test: added an expo back off to prevent RESOURCE_EXHAUSTED exception (#…
e728d0e 
…630)

* test: added an expo back off to prevent RESOURCE_EXHAUSTED exception

* modified comment

* changed arrow func-> regular
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
@release-please
chore: release 3.1.4 (#630)
19a8015 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.1.4](https://www.github.com/googleapis/nodejs-dlp/compare/v3.1.3...v3.1.4) (2021-06-29)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#629](https://www.github.com/googleapis/nodejs-dlp/issues/629)) ([e8b89d0](https://www.github.com/googleapis/nodejs-dlp/commit/e8b89d08986c7d3815741e39f057d8f99ea21df0))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@Shabirmean Shabirmean mentioned this pull request Feb 16, 2023
Merged
@leejh3224 leejh3224 mentioned this pull request Oct 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labtopia @ace-n