Update memcached sample #619

michaelawyu · 2018-05-12T01:34:59Z

No description provided.

codecov · 2018-05-12T01:51:45Z

Codecov Report

Merging #619 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6c836...66f19f5. Read the comment docs.

ace-n

LGTM other than one question. Feel free to merge once that question is resolved.

ace-n · 2018-05-17T21:25:39Z

appengine/memcached/app.js

-if (process.env.USE_GAE_MEMCACHE) {
-  MEMCACHE_URL = `${process.env.GAE_MEMCACHE_HOST}:${process.env.GAE_MEMCACHE_PORT}`;
-}
+let MEMCACHE_URL = process.env.MEMCACHE_URL;


Two questions:

Is MEMCACHE_URL guaranteed to be defined? (Both on GAE, and in our tutorials)

If not, is there ever a situation where 127.0.0.1:11211 makes sense as a default MEMCACHE_URL value?

Node-on-standard doesn't have built-in memcached service anymore :( 127.0.0.1:11211 is no longer available. In our tutorials there is a clear instruction suggesting users to deploy a free memcached instance provided by RedisLab.

* chore(main): release 3.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: corrected batch tests * removed report files * fixed lints and reversed hybrid test

* chore(main): release 3.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: corrected batch tests * removed report files * fixed lints and reversed hybrid test

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [uuid](https://togithub.com/uuidjs/uuid) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/uuid/8.3.2/9.0.0) | [![age](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/compatibility-slim/8.3.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/uuid/9.0.0/confidence-slim/8.3.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>uuidjs/uuid</summary> ### [`v9.0.0`](https://togithub.com/uuidjs/uuid/blob/HEAD/CHANGELOG.md#900-httpsgithubcomuuidjsuuidcomparev832v900-2022-09-05) [Compare Source](https://togithub.com/uuidjs/uuid/compare/v8.3.2...v9.0.0) ##### ⚠ BREAKING CHANGES - Drop Node.js 10.x support. This library always aims at supporting one EOLed LTS release which by this time now is 12.x which has reached EOL 30 Apr 2022. - Remove the minified UMD build from the package. Minified code is hard to audit and since this is a widely used library it seems more appropriate nowadays to optimize for auditability than to ship a legacy module format that, at best, serves educational purposes nowadays. For production browser use cases, users should be using a bundler. For educational purposes, today's online sandboxes like replit.com offer convenient ways to load npm modules, so the use case for UMD through repos like UNPKG or jsDelivr has largely vanished. - Drop IE 11 and Safari 10 support. Drop support for browsers that don't correctly implement const/let and default arguments, and no longer transpile the browser build to ES2015. This also removes the fallback on msCrypto instead of the crypto API. Browser tests are run in the first supported version of each supported browser and in the latest (as of this commit) version available on Browserstack. ##### Features - optimize uuid.v1 by 1.3x uuid.v4 by 4.3x (430%) ([#597](https://togithub.com/uuidjs/uuid/issues/597)) ([3a033f6](https://togithub.com/uuidjs/uuid/commit/3a033f6bab6bb3780ece6d645b902548043280bc)) - remove UMD build ([#645](https://togithub.com/uuidjs/uuid/issues/645)) ([e948a0f](https://togithub.com/uuidjs/uuid/commit/e948a0f22bf22f4619b27bd913885e478e20fe6f)), closes [#620](https://togithub.com/uuidjs/uuid/issues/620) - use native crypto.randomUUID when available ([#600](https://togithub.com/uuidjs/uuid/issues/600)) ([c9e076c](https://togithub.com/uuidjs/uuid/commit/c9e076c852edad7e9a06baaa1d148cf4eda6c6c4)) ##### Bug Fixes - add Jest/jsdom compatibility ([#642](https://togithub.com/uuidjs/uuid/issues/642)) ([16f9c46](https://togithub.com/uuidjs/uuid/commit/16f9c469edf46f0786164cdf4dc980743984a6fd)) - change default export to named function ([#545](https://togithub.com/uuidjs/uuid/issues/545)) ([c57bc5a](https://togithub.com/uuidjs/uuid/commit/c57bc5a9a0653273aa639cda9177ce52efabe42a)) - handle error when parameter is not set in v3 and v5 ([#622](https://togithub.com/uuidjs/uuid/issues/622)) ([fcd7388](https://togithub.com/uuidjs/uuid/commit/fcd73881692d9fabb63872576ba28e30ff852091)) - run npm audit fix ([#644](https://togithub.com/uuidjs/uuid/issues/644)) ([04686f5](https://togithub.com/uuidjs/uuid/commit/04686f54c5fed2cfffc1b619f4970c4bb8532353)) - upgrading from uuid3 broken link ([#568](https://togithub.com/uuidjs/uuid/issues/568)) ([1c849da](https://togithub.com/uuidjs/uuid/commit/1c849da6e164259e72e18636726345b13a7eddd6)) ##### build - drop Node.js 8.x from babel transpile target ([#603](https://togithub.com/uuidjs/uuid/issues/603)) ([aa11485](https://togithub.com/uuidjs/uuid/commit/aa114858260402107ec8a1e1a825dea0a259bcb5)) - drop support for legacy browsers (IE11, Safari 10) ([#604](https://togithub.com/uuidjs/uuid/issues/604)) ([0f433e5](https://togithub.com/uuidjs/uuid/commit/0f433e5ec444edacd53016de67db021102f36148)) - drop node 10.x to upgrade dev dependencies ([#653](https://togithub.com/uuidjs/uuid/issues/653)) ([28a5712](https://togithub.com/uuidjs/uuid/commit/28a571283f8abda6b9d85e689f95b7d3ee9e282e)), closes [#643](https://togithub.com/uuidjs/uuid/issues/643) ##### [8.3.2](https://togithub.com/uuidjs/uuid/compare/v8.3.1...v8.3.2) (2020-12-08) ##### Bug Fixes - lazy load getRandomValues ([#537](https://togithub.com/uuidjs/uuid/issues/537)) ([16c8f6d](https://togithub.com/uuidjs/uuid/commit/16c8f6df2f6b09b4d6235602d6a591188320a82e)), closes [#536](https://togithub.com/uuidjs/uuid/issues/536) ##### [8.3.1](https://togithub.com/uuidjs/uuid/compare/v8.3.0...v8.3.1) (2020-10-04) ##### Bug Fixes - support expo>=39.0.0 ([#515](https://togithub.com/uuidjs/uuid/issues/515)) ([c65a0f3](https://togithub.com/uuidjs/uuid/commit/c65a0f3fa73b901959d638d1e3591dfacdbed867)), closes [#375](https://togithub.com/uuidjs/uuid/issues/375) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-dataproc).

Update app.standard.yaml

34efc25

michaelawyu requested a review from ace-n May 12, 2018 01:34

michaelawyu added 2 commits May 11, 2018 18:36

Update app.js

885d875

Update app.flexible.yaml

dd80dcd

ace-n approved these changes May 17, 2018

View reviewed changes

Merge branch 'master' into michaelawyu-patch-3

66f19f5

michaelawyu merged commit 5091a97 into master May 23, 2018

michaelawyu deleted the michaelawyu-patch-3 branch May 23, 2018 01:00

snyk-bot mentioned this pull request Nov 11, 2021

[Snyk] Security upgrade natural from 0.5.1 to 5.1.11 ninadhatkar/nodejs-docs-samples#159

Open

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-automl #2841

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: corrected batch tests (#619)

6f9b433

* chore: corrected batch tests * removed report files * fixed lints and reversed hybrid test

ace-n mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-translate #2862

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: corrected batch tests (#619)

a102a02

* chore: corrected batch tests * removed report files * fixed lints and reversed hybrid test

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: corrected batch tests (#619)

d2c4317

* chore: corrected batch tests * removed report files * fixed lints and reversed hybrid test

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: corrected batch tests (#619)

a2fe318

* chore: corrected batch tests * removed report files * fixed lints and reversed hybrid test

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: corrected batch tests (#619)

1efd2c6

* chore: corrected batch tests * removed report files * fixed lints and reversed hybrid test

NimJay mentioned this pull request Nov 19, 2022

migrate code from googleapis/nodejs-dataproc #2878

Merged

dlminvestments mentioned this pull request Mar 25, 2024

[Snyk] Security upgrade markdown-it from 12.3.2 to 13.0.2 dlminvestments/nodejs-docs-samples#482

Open

aqualen mentioned this pull request Mar 25, 2024

[Snyk] Security upgrade markdown-it from 12.3.2 to 13.0.2 aqualen/nodejs-docs-samples#147

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update memcached sample #619

Update memcached sample #619

michaelawyu commented May 12, 2018

codecov bot commented May 12, 2018 •

edited

Loading

ace-n left a comment •

edited

Loading

ace-n May 17, 2018

michaelawyu May 23, 2018

Update memcached sample #619

Update memcached sample #619

Conversation

michaelawyu commented May 12, 2018

codecov bot commented May 12, 2018 • edited Loading

Codecov Report

ace-n left a comment • edited Loading

Choose a reason for hiding this comment

ace-n May 17, 2018

Choose a reason for hiding this comment

michaelawyu May 23, 2018

Choose a reason for hiding this comment

codecov bot commented May 12, 2018 •

edited

Loading

ace-n left a comment •

edited

Loading