Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handler section to app.yaml #618

Closed
wants to merge 1 commit into from
Closed

Add handler section to app.yaml #618

wants to merge 1 commit into from

Conversation

michaelawyu
Copy link
Contributor

No description provided.

@michaelawyu michaelawyu requested a review from ace-n May 12, 2018 01:34
ace-n
ace-n approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if @steren has signed off on it.

@steren
Copy link
Contributor

steren commented May 18, 2018 •
edited
Loading

Do not submit this commit.

handlers is still optional. No need to add some.

What has changed is that if present, handlers.script must be auto.
If our sample do not use handlers.script, then no need to change anything.

@michaelawyu
Copy link
Contributor Author

I seem to have misunderstood the email Steren sent a little bit :( Really sorry about this. I'll close the commit now.

@steren
Copy link
Contributor

steren commented May 20, 2018

No worries, thanks for your help

@snyk-bot snyk-bot mentioned this pull request Nov 11, 2021
Open
ahrarmonsur pushed a commit that referenced this pull request Nov 8, 2022
@release-please
chore(main): release 3.0.0 (#618)
37ca441 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 8, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 10, 2022
@release-please
chore(main): release 3.0.0 (#618)
0c13388 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@summer-ji-eng
feat: add minimum wrapper for compute LRO method (#618)
5274f07
This was referenced Nov 14, 2022
Closed
Merged
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@gcf-owl-bot @bcoe
build(node): update client library version in samples metadata (#1356) (
94b658e 
#618)

* build(node): add feat in node post-processor to add client library version number in snippet metadata

Co-authored-by: Benjamin E. Coe <[email protected]>
Source-Link: googleapis/synthtool@d337b88
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@gcf-owl-bot @bcoe
build(node): update client library version in samples metadata (#1356) (
51d20b5 
#618)

* build(node): add feat in node post-processor to add client library version number in snippet metadata

Co-authored-by: Benjamin E. Coe <[email protected]>
Source-Link: googleapis/synthtool@d337b88
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641
ace-n pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.4.1 (#618)
9e09d5b 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.4.1](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.4.0...v3.4.1) (2021-09-15)


### Bug Fixes

* **deps:** require google-gax v2.24.1 ([#589](https://www.github.com/googleapis/nodejs-video-intelligence/issues/589)) ([6af1a84](https://www.github.com/googleapis/nodejs-video-intelligence/commit/6af1a84112ab56a3ff2862ff7a5eda0da9772244))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@gcf-owl-bot @bcoe
build(node): update client library version in samples metadata (#1356) (
9ae103a 
#618)

* build(node): add feat in node post-processor to add client library version number in snippet metadata

Co-authored-by: Benjamin E. Coe <[email protected]>
Source-Link: googleapis/synthtool@d337b88
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641
@ace-n ace-n mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore: release 3.4.1 (#618)
42b1e8e 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.4.1](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.4.0...v3.4.1) (2021-09-15)


### Bug Fixes

* **deps:** require google-gax v2.24.1 ([#589](https://www.github.com/googleapis/nodejs-video-intelligence/issues/589)) ([6af1a84](https://www.github.com/googleapis/nodejs-video-intelligence/commit/6af1a84112ab56a3ff2862ff7a5eda0da9772244))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@release-please @ahrarmonsur
chore: release 3.4.1 (#618)
87274e4 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.4.1](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.4.0...v3.4.1) (2021-09-15)


### Bug Fixes

* **deps:** require google-gax v2.24.1 ([#589](https://www.github.com/googleapis/nodejs-video-intelligence/issues/589)) ([6af1a84](https://www.github.com/googleapis/nodejs-video-intelligence/commit/6af1a84112ab56a3ff2862ff7a5eda0da9772244))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@summer-ji-eng
feat: add minimum wrapper for compute LRO method (#618)
864bb21
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@summer-ji-eng
feat: add minimum wrapper for compute LRO method (#618)
c66d806
@leejh3224 leejh3224 mentioned this pull request Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelawyu @steren @ace-n