Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to include region #524

Closed
wants to merge 2 commits into from

Conversation

art-tts
Copy link

@art-tts art-tts commented Nov 14, 2017

Including region in example, if you're in Europe the example will not work, and will instead spit out errors.

Including region in example, if you're in Europe the example will not work, and will instead spit out errors.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #524 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          13       13           
  Lines         458      458           
=======================================
  Hits          445      445           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6886ef8...902c8fc. Read the comment docs.

@art-tts
Copy link
Author

art-tts commented Nov 14, 2017

I signed it!

@@ -46,6 +46,7 @@ run the sample as:
--registry_id=my-registry \
--device_id=my-node-device \
--private_key_file=../rsa_private.pem \
--cloud_region=us-west1 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. I'm not 100% sure we're in the us-west1 region yet, can you change this to us-central1, europe-west1, or asia-east1?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify? I can modify.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, us-central1 is definitely supported, others I didn't list are not showing up for me.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@gguuss
Copy link
Contributor

gguuss commented Dec 18, 2017

@googlebot I signed it!

@fhinkel
Copy link
Contributor

fhinkel commented Jun 5, 2018

@art-tts Thanks for the PR! Do you want to make the requested change?

@gguuss
Copy link
Contributor

gguuss commented Jul 17, 2018

Closing, instructions must have been updated in a separate PR.

@gguuss gguuss closed this Jul 17, 2018
ahrarmonsur pushed a commit that referenced this pull request Nov 8, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
kweinmeister pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: Nicole Zhu <[email protected]>
Co-authored-by: Justin Beckwith <[email protected]>
ace-n pushed a commit that referenced this pull request Nov 11, 2022
Co-authored-by: Nicole Zhu <[email protected]>
Co-authored-by: Justin Beckwith <[email protected]>
ace-n pushed a commit that referenced this pull request Nov 11, 2022
Co-authored-by: Nicole Zhu <[email protected]>
Co-authored-by: Justin Beckwith <[email protected]>
ace-n pushed a commit that referenced this pull request Nov 11, 2022
ace-n pushed a commit that referenced this pull request Nov 11, 2022
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ace-n pushed a commit that referenced this pull request Nov 15, 2022
ace-n pushed a commit that referenced this pull request Nov 15, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants