Add Prediction API sample. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (err) { | ||
| return callback(err); | ||
| } | ||
| // The createScopedRequired method returns true when running on GAE or a |
There was a problem hiding this comment.
Does 'running on GAE' apply for node? Or does this mean Managed VMs?
There was a problem hiding this comment.
I think it means Managed VMs, the comment came from the googleapis README
|
lgtm |
| // are pulled from the GCE metadata server. | ||
| // See https://cloud.google.com/compute/docs/authentication for more | ||
| // information. | ||
| if (authClient.createScopedRequired && authClient.createScopedRequired()) { |
There was a problem hiding this comment.
This really shouldn't be required, if it is, we should open a bug on the API client. Python's does this automatically.
jmdobry
force-pushed
the
prediction
branch
2 times, most recently
from
945f503
to
cc0af58
Compare
|
@jonparrott looks good? |
|
LGTM. |
ivanmkc
pushed a commit
that referenced
this pull request
Nov 3, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
grayside
pushed a commit
that referenced
this pull request
Nov 8, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
NimJay
pushed a commit
that referenced
this pull request
Nov 9, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
…nter-insights (#2817) - feat: initial generation of templated files - feat: add initial samples (#2) - chore(deps): update dependency mocha to v9 (#3) - chore: release 1.0.0 (#1) - chore: release 1.0.1 (#12) - chore: release 1.0.2 (#18) - chore: release 1.1.0 (#21) - chore: release 1.2.0 (#26) - chore: release 1.2.1 (#29) - chore: release 1.3.0 (#36) - chore: release 1.4.0 (#40) - samples: get operation (#52) - samples: create conversation, create analysis, export data to BigQuery (#34) - samples: enable pubsub notifications (#48) - samples: modify TTL in create conversation with TTL sample (#57) - samples: create topic model (#49) - chore: release 1.5.0 (#58) - samples: set project-level TTL (#51) - samples: create custom highlights (#53) - chore: release 1.6.0 (#65) - chore: release 1.7.0 (#69) - chore: release 1.8.0 (#75) - chore: release 1.9.0 (#81) - chore(main): release 1.11.0 (#107) - build: add retries for flaky test (#109) - build!: update library to use Node 12 (#122) - chore(main): release 2.0.0 (#124) - fix(deps): update dependency @google-cloud/bigquery to v6 (#127) - fix(deps): update dependency @google-cloud/pubsub to v3 (#126) - chore(main): release 2.0.1 (#129) - chore(main): release 2.1.0 (#134) - chore(main): release 2.1.1 (#139) - chore(deps): update dependency uuid to v9 (#142)
This was referenced Nov 11, 2022
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
Update fulltext, safe search, web, and web geo samples to match canonicals
kweinmeister
pushed a commit
that referenced
this pull request
Nov 18, 2022
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
…oudPlatform#52) Co-authored-by: Eno Compton <[email protected]>
irataxy
pushed a commit
that referenced
this pull request
Jan 18, 2023
* chore(main): release 0.3.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
grayside
pushed a commit
that referenced
this pull request
Jan 18, 2023
* chore(main): release 0.3.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing Node.js sample for these docs: https://cloud.google.com/prediction/docs/developer-guide#predictionfromappengine