Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(terminology): update language to follow recommendations #1981

Merged
merged 3 commits into from
Oct 5, 2020

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2020
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 23, 2020
@JustinBeckwith
Copy link
Contributor Author

@ace-n @grant @grayside it looks like the merge is getting blocked on failing functions tests :) Could I trouble y'all to take a look?

@grant
Copy link
Contributor

grant commented Sep 24, 2020

@ace-n ?

Error: Invalid Credentials


Unable to determine if billing is enabled on specified project, assuming billing is enabled

  2 passing (2s)
  1 failing

  1) functions/billing tests
       disables billing
         functions_billing_stop
           should disable billing when budget is exceeded:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(response.body.includes('Billing disabled'))

      + expected - actual

      -false
      +true

      at Context.it (test/index.test.js:131:16)
      at process._tickCallback (internal/process/next_tick.js:68:7)



(node:54) UnhandledPromiseRejectionWarning: ChildProcessError: Command failed: functions-framework --target=stopBilling --signature-type=event --port 8081
Error: Invalid Credentials
    at Gaxios._request (/tmpfs/src/github/nodejs-docs-samples/functions/billing/node_modules/gaxios/build/src/gaxios.js:89:23)
    at process._tickCallback (internal/process/next_tick.js:68:7)
 `functions-framework --target=stopBilling --signature-type=event --port 8081` (exited with error code null)
    at callback (/tmpfs/src/github/nodejs-docs-samples/functions/billing/node_modules/child-process-promise/lib/index.js:33:27)
    at ChildProcess.exithandler (child_process.js:301:5)
    at ChildProcess.emit (events.js:198:13)
    at maybeClose (internal/child_process.js:982:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
(node:54) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test: `mocha test/index.test.js --timeout=5000`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/node/.npm/_logs/2020-09-23T05_04_57_724Z-debug.log


[ID: 1158671] Build finished after 61 secs, exit value: 1


Warning: Permanently added 'localhost' (ECDSA) to the list of known hosts.
[22:04:59] Collecting build artifacts from build VM
Build script failed with exit code: 1

This was referenced Mar 20, 2022
@averikitsch averikitsch deleted the terms branch September 15, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants