fix #1710: async pooling bug in MySQL #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
shubha-rajan
force-pushed
the
fix-mysql-pooling-bug
branch
from
ad39b71
to
2e6f585
Compare
kurtisvg
approved these changes
Apr 10, 2020
cloud-sql/mysql/mysql/server.js
Outdated
| ); | ||
| console.log(`Ensured that table 'votes' exists`); | ||
| } catch (e) { | ||
| console.log(`Got error: ${e}`); |
There was a problem hiding this comment.
Should this fail instead of just catch and throw?
cloud-sql/mysql/mysql/server.js
Outdated
|
|
||
| createPool() | ||
| .then(() => (schemaReady = ensureSchema())) | ||
| .catch((error) => console.log(error)); |
There was a problem hiding this comment.
Same with this - does it fail the execution if this pool doesn't start?
fhinkel
approved these changes
Apr 10, 2020
|
I'll wait with the merge until @kurtisvg 's comments are approved |
JustinBeckwith
suggested changes
Apr 12, 2020
There was a problem hiding this comment.
The feedback from @kurtisvg was spot on. In general, we should avoid capturing and swallowing errors. Let it throw!
shubha-rajan
force-pushed
the
fix-mysql-pooling-bug
branch
from
09d9586
to
a8b7e21
Compare
|
@JustinBeckwith do you still have objections for this PR? |
JustinBeckwith
approved these changes
Apr 20, 2020
|
@shubha-rajan Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1710
Ensures that the pool and table are created before serving any requests.