Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor repo tools usage #1639

Merged
merged 24 commits into from
Mar 30, 2020
Merged

chore: refactor repo tools usage #1639

merged 24 commits into from
Mar 30, 2020

Conversation

sofisl
Copy link
Collaborator

@sofisl sofisl commented Mar 26, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 26, 2020
fhinkel
fhinkel approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe split the PR in those changes that don't fail the tests, so it's easier to review the failing ones.

@sofisl sofisl marked this pull request as ready for review March 30, 2020 23:48
@sofisl sofisl merged commit 3692a10 into GoogleCloudPlatform:master Mar 30, 2020
@noerog noerog mentioned this pull request Apr 20, 2020
Merged
@dlminvestments dlminvestments mentioned this pull request Jul 10, 2023
Open
@aqualen aqualen mentioned this pull request Jul 11, 2023
Open
@pedroarapua pedroarapua mentioned this pull request Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@ace-n ace-n Awaiting requested review from ace-n

@gguuss gguuss Awaiting requested review from gguuss

@grant grant Awaiting requested review from grant

@happyhuman happyhuman Awaiting requested review from happyhuman

@jsimonweb jsimonweb Awaiting requested review from jsimonweb

@leahecole leahecole Awaiting requested review from leahecole

@michaelawyu michaelawyu Awaiting requested review from michaelawyu

@nnegrey nnegrey Awaiting requested review from nnegrey

@noerog noerog Awaiting requested review from noerog

@ricalo ricalo Awaiting requested review from ricalo

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sofisl @fhinkel @googlebot