Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update functions/background sample #1353

Merged
merged 17 commits into from
Jun 12, 2019
Merged

Update functions/background sample #1353

merged 17 commits into from
Jun 12, 2019

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jun 10, 2019

  • Use system tests (with functions-framework-nodejs)
  • Update sample to Node 8 standards
  • Fix lint

@ace-n ace-n requested a review from fhinkel June 10, 2019 20:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 10, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@ace-n ace-n added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@ace-n ace-n merged commit 8aeb3d1 into master Jun 12, 2019
@ace-n ace-n deleted the gcf-background branch June 12, 2019 21:59
@dlminvestments dlminvestments mentioned this pull request Jan 10, 2023
Merged
@aqualen aqualen mentioned this pull request Nov 28, 2023
Open
@aqualen aqualen mentioned this pull request Dec 14, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Dec 15, 2023
Open
@aqualen aqualen mentioned this pull request Jan 5, 2024
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ace-n @fhinkel @googlebot @kokoro-team