Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow getClient #824

Closed
blasco opened this issue Nov 7, 2018 · 5 comments
Closed

Slow getClient #824

blasco opened this issue Nov 7, 2018 · 5 comments
Assignees

Comments

@blasco
Copy link

blasco commented Nov 7, 2018

So I want to update my device configuration from a Firebase Cloud Function.
I've created a JWT service account that allows the firebase functions to manage all the devices.
The getDevice() function takes 2 seconds before I get the client...
Is threre a way to speed this up?
Every time I want to call the function I need to wait to get this client. Is there another approach? Or is it not normal that it takes for so long?

@fhinkel
Copy link
Contributor

fhinkel commented Nov 15, 2018

@ace-n, can you route this to the appropriate Cloud Function person please. Thanks

@ace-n
Copy link
Contributor

ace-n commented Nov 15, 2018

/cc @samtstern

Does this help?

@fhinkel
Copy link
Contributor

fhinkel commented Feb 28, 2019

ping @samstern, please have a look.

@samtstern
Copy link

Sorry I don't think I am the right person, I don't know about this.

If getClient() produces a singleton you can share you can call it outside of the cloud function body though.

@ace-n
Copy link
Contributor

ace-n commented Jun 6, 2019

Closing this due to a lack of activity. @j-blasco please reply here (or create another issue) if this is still a problem for you (and the suggestions above didn't help) - thanks!

@ace-n ace-n closed this as completed Jun 6, 2019
telpirion pushed a commit that referenced this issue Nov 16, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [yargs](https://yargs.js.org/) ([source](https://togithub.com/yargs/yargs)) | dependencies | major | [`^15.0.0` -> `^16.0.0`](https://renovatebot.com/diffs/npm/yargs/15.4.1/16.0.1) |

---

### Release Notes

<details>
<summary>yargs/yargs</summary>

### [`v16.0.1`](https://togithub.com/yargs/yargs/blob/master/CHANGELOG.md#&#8203;1601-httpswwwgithubcomyargsyargscomparev1600v1601-2020-09-09)

[Compare Source](https://togithub.com/yargs/yargs/compare/v16.0.0...v16.0.1)

### [`v16.0.0`](https://togithub.com/yargs/yargs/blob/master/CHANGELOG.md#&#8203;1600-httpswwwgithubcomyargsyargscomparev1542v1600-2020-09-09)

[Compare Source](https://togithub.com/yargs/yargs/compare/v15.4.1...v16.0.0)

##### ⚠ BREAKING CHANGES

-   tweaks to ESM/Deno API surface: now exports yargs function by default; getProcessArgvWithoutBin becomes hideBin; types now exported for Deno.
-   find-up replaced with escalade; export map added (limits importable files in Node >= 12); [email protected] (new decamelize/camelcase implementation).
-   **usage:** single character aliases are now shown first in help output
-   rebase helper is no longer provided on yargs instance.
-   drop support for EOL Node 8 ([#&#8203;1686](https://togithub.com/yargs/yargs/issues/1686))

##### Features

-   adds strictOptions() ([#&#8203;1738](https://www.github.com/yargs/yargs/issues/1738)) ([b215fba](https://www.github.com/yargs/yargs/commit/b215fba0ed6e124e5aad6cf22c8d5875661c63a3))
-   **helpers:** rebase, Parser, applyExtends now blessed helpers ([#&#8203;1733](https://www.github.com/yargs/yargs/issues/1733)) ([c7debe8](https://www.github.com/yargs/yargs/commit/c7debe8eb1e5bc6ea20b5ed68026c56e5ebec9e1))
-   adds support for ESM and Deno ([#&#8203;1708](https://www.github.com/yargs/yargs/issues/1708)) ([ac6d5d1](https://www.github.com/yargs/yargs/commit/ac6d5d105a75711fe703f6a39dad5181b383d6c6))
-   drop support for EOL Node 8 ([#&#8203;1686](https://www.github.com/yargs/yargs/issues/1686)) ([863937f](https://www.github.com/yargs/yargs/commit/863937f23c3102f804cdea78ee3097e28c7c289f))
-   i18n for ESM and Deno ([#&#8203;1735](https://www.github.com/yargs/yargs/issues/1735)) ([c71783a](https://www.github.com/yargs/yargs/commit/c71783a5a898a0c0e92ac501c939a3ec411ac0c1))
-   tweaks to API surface based on user feedback ([#&#8203;1726](https://www.github.com/yargs/yargs/issues/1726)) ([4151fee](https://www.github.com/yargs/yargs/commit/4151fee4c33a97d26bc40de7e623e5b0eb87e9bb))
-   **usage:** single char aliases first in help ([#&#8203;1574](https://www.github.com/yargs/yargs/issues/1574)) ([a552990](https://www.github.com/yargs/yargs/commit/a552990c120646c2d85a5c9b628e1ce92a68e797))

##### Bug Fixes

-   **yargs:** add missing command(module) signature ([#&#8203;1707](https://www.github.com/yargs/yargs/issues/1707)) ([0f81024](https://www.github.com/yargs/yargs/commit/0f810245494ccf13a35b7786d021b30fc95ecad5)), closes [#&#8203;1704](https://www.github.com/yargs/yargs/issues/1704)

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-vision).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants