Cleanup App Engine samples and re-work tests. (#354)

GoogleCloudPlatform · Nov 17, 2022 · bd5acb9 · bd5acb9
1 parent 459044f
commit bd5acb9
Show file tree

Hide file tree

Showing 4 changed files with 3,025 additions and 97 deletions.
diff --git a/video-intelligence/analyze.js b/video-intelligence/analyze.js
@@ -132,7 +132,7 @@ function analyzeShots (gcsUri) {
   // [END analyze_shots]
 }
 
-const cli = require(`yargs`)
+require(`yargs`) // eslint-disable-line
   .demand(1)
   .command(
     `faces <gcsUri>`,

diff --git a/video-intelligence/package.json b/video-intelligence/package.json
@@ -2,16 +2,31 @@
   "name": "nodejs-docs-samples-videointelligence",
   "version": "0.0.1",
   "private": true,
-  "license": "Apache Version 2.0",
+  "license": "Apache-2.0",
   "author": "Google Inc.",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
+  },
+  "cloud": {
+    "requiresKeyFile": true,
+    "requiresProjectId": true
+  },
+  "engines": {
+    "node": ">=4.3.2"
+  },
   "scripts": {
-    "test": "cd ..; npm run st -- --verbose video/system-test/*.test.js"
+    "lint": "samples lint",
+    "pretest": "npm run lint",
+    "system-test": "ava -T 10m --verbose system-test/*.test.js",
+    "test": "npm run system-test"
   },
   "dependencies": {
     "@google-cloud/videointelligence": "https://storage.googleapis.com/videointelligence-alpha/videointelligence-nodejs.tar.gz",
-    "yargs": "7.0.2"
+    "yargs": "7.1.0"
   },
-  "engines": {
-    "node": ">=4.3.2"
+  "devDependencies": {
+    "@google-cloud/nodejs-repo-tools": "1.3.1",
+    "ava": "0.19.1"
   }
 }
diff --git a/video-intelligence/system-test/analyze.test.js b/video-intelligence/system-test/analyze.test.js
@@ -17,26 +17,27 @@
 
 'use strict';
 
-require(`../../system-test/_setup`);
 const path = require(`path`);
+const test = require(`ava`);
+const tools = require(`@google-cloud/nodejs-repo-tools`);
 
 const cmd = `node analyze.js`;
 const cwd = path.join(__dirname, `..`);
 
 // analyze_faces
 test(`should analyze faces`, async (t) => {
-  const output = await runAsync(`${cmd} faces gs://nodejs-docs-samples/video/google_gmail.mp4`, cwd);
+  const output = await tools.runAsync(`${cmd} faces gs://nodejs-docs-samples/video/google_gmail.mp4`, cwd);
   t.regex(output, /Thumbnail size: \d+/);
 });
 
 // analyze_labels
 test(`should analyze labels`, async (t) => {
-  const output = await runAsync(`${cmd} labels gs://nodejs-docs-samples/video/cat.mp4`, cwd);
+  const output = await tools.runAsync(`${cmd} labels gs://nodejs-docs-samples/video/cat.mp4`, cwd);
   t.regex(output, /Label description: Whiskers/);
 });
 
 // analyze_shots
 test(`should analyze shots`, async (t) => {
-  const output = await runAsync(`${cmd} shots gs://nodejs-docs-samples/video/gbike_dinosaur.mp4`, cwd);
+  const output = await tools.runAsync(`${cmd} shots gs://nodejs-docs-samples/video/gbike_dinosaur.mp4`, cwd);
   t.regex(output, /Scene 0:/);
 });