Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the wait for Cilium readiness to the end #221

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

jingyuanliang
Copy link
Member

Do it just before writing out CNI config so other steps can complete earlier without waiting for Cilium.

Do it just before writing out CNI config so other steps can complete
earlier without waiting for Cilium.
@jingyuanliang
Copy link
Member Author

/assign @aojea
/assign @MrHohn
/assign @Ramkumar-K

@google-oss-prow
Copy link
Contributor

@jingyuanliang: GitHub didn't allow me to assign the following users: Ramkumar-K.

Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @aojea
/assign @MrHohn
/assign @Ramkumar-K

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ramkumar-K
Copy link
Collaborator

/lgtm
/approve

@google-oss-prow
Copy link
Contributor

@Ramkumar-K: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 8, 2023
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, MrHohn, Ramkumar-K

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MrHohn,jingyuanliang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e42f135 into GoogleCloudPlatform:master Aug 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants