-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base image to use debian-iptables #116
Conversation
@MrHohn: GitHub didn't allow me to assign the following users: prameshj. Note that only GoogleCloudPlatform members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The debian-iptables version is taken from kubernetes/release#2373. |
/lgtm |
@prameshj: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From the top post, the 30003 rule seems to change from
to
I have double checked on my dev cluster and there seems to be something strange with the busybox base image such that the ip rule command doesn't show all the field.. Executing the same command on the node directly (rather from the netd pod) I see:
(Thanks to @sypakine for noticing this strange bit.) |
/lgtm Thanks for confirming @MrHohn! |
Thanks to both for the reviews. Giving one more update. Upon further checking, it turned out the policy routing rules were correctly installed - I logged into one of the netd pods (with the alpine base image), updated the So the issue I originally described might just be a red-herring. Anyway, still good to migrate to the deian-iptables image and I will follow the general release schedule. |
During a recent debug session, I found out that the previously added ip rules for DNS traffic (#114) don't fully work as expected.
With the current alpine base image, I saw the sport/dport field being omitted:
It is likely the ip rule dependencies is at a lower version in the alpine image. Update to use the debian-iptables image from k8s seems to resolve the problem. Built a test image with the base image swapped I saw:
/assign @prameshj @sypakine