-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies in Go services #2716
Bump dependencies in Go services #2716
Conversation
header-check failed for generated files. I am not sure if I should do anything with it. Feel free to edit if necessary. |
Should I revert the Go version to 1.22 or update to Go 1.23 in places that I have missed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (posthumously, should have refreshed before review)
Background
I noticed that the
pb.go
files where not regenerated for a long time and thus the generated code was using deprecated Go module (github.com/golang/protobuf
)I think that without regenerating it might not even work with
google.golang.org/grpc v1.66.0
. At least this is what I noticed when working on signalfx#152.Fixes
N/A
Change Summary
go.mod
files to1.23
(theDockerfile
are already using Go 1.23.genproto.sh
so that it works fine with latest protoc tooling. References:Additional Notes
as
toAS
in Dockerfiles to get rid ofdocker build
warningTesting Procedure
Related PRs or Issues