Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies in Go services #2716

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

pellared
Copy link
Contributor

@pellared pellared commented Sep 5, 2024

Background

I noticed that the pb.go files where not regenerated for a long time and thus the generated code was using deprecated Go module (github.com/golang/protobuf)

I think that without regenerating it might not even work with google.golang.org/grpc v1.66.0. At least this is what I noticed when working on signalfx#152.

Fixes

N/A

Change Summary

Additional Notes

  • nit: I also replaced as to AS in Dockerfiles to get rid of docker build warning

Testing Procedure

Related PRs or Issues

@pellared pellared requested review from yoshi-approver and a team as code owners September 5, 2024 08:01
@pellared
Copy link
Contributor Author

pellared commented Sep 5, 2024

header-check failed for generated files. I am not sure if I should do anything with it. Feel free to edit if necessary.

@pellared
Copy link
Contributor Author

pellared commented Sep 5, 2024

Should I revert the Go version to 1.22 or update to Go 1.23 in places that I have missed?

@pellared pellared requested a review from bourgeoisor September 5, 2024 15:51
protos/demo.proto Outdated Show resolved Hide resolved
@pellared pellared requested a review from bourgeoisor September 5, 2024 16:12
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bourgeoisor bourgeoisor merged commit ca90f35 into GoogleCloudPlatform:main Sep 5, 2024
5 of 6 checks passed
@pellared pellared deleted the google-bump-grpc branch September 5, 2024 17:35
Copy link

@mike-ensor mike-ensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (posthumously, should have refreshed before review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants