Add support for custom containers for workbench instances

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

workbench: added `container_image` field to `google_workbench_instance` resource

[bcreddy-gcp]

/gcbrun

[rileykarson]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 167 insertions(+))
Terraform Beta: Diff ( 3 files changed, 167 insertions(+))
TF Conversion: Diff ( 1 file changed, 41 insertions(+))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkbenchInstance_workbenchInstanceBasicContainerExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkbenchInstance_workbenchInstanceBasicContainerExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

Error: Error creating Instance: Post "https://notebooks.googleapis.com/v2/projects/ci-test-project-188019/locations/us-west1-a/instances?alt=json&instanceId=tf-test-workbench-instancei6uzd1hvcq": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

That error generally indicates an issue with the API- it's a synchronous request timeout where an initial response took longer than 30s to get back.

[bcreddy-gcp]

Could you retest this? I believe we had an outage in us-west1-a.

[rileykarson]

Sure!

/gcbrun

[melinath]

Drive-by /gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 167 insertions(+))
Terraform Beta: Diff ( 3 files changed, 167 insertions(+))
TF Conversion: Diff ( 1 file changed, 41 insertions(+))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[rileykarson]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 167 insertions(+))
Terraform Beta: Diff ( 3 files changed, 167 insertions(+))
TF Conversion: Diff ( 1 file changed, 41 insertions(+))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log