Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spanner database iam binding import #995

Merged

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Dec 5, 2018


[all]

[terraform]

Fix spanner database iam binding import

[terraform-beta]

Fix spanner database iam binding import

[ansible]

[inspec]

@emilymye emilymye force-pushed the spanner_db_fix branch 2 times, most recently from 93e1ba6 to bb3629e Compare December 5, 2018 21:52
@emilymye emilymye requested a review from paddycarver December 5, 2018 23:04
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love it, but I'll get over it.

No idea why downstream PRs weren't generated?

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#197
depends: hashicorp/terraform-provider-google#2603
depends: modular-magician/ansible#145

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 7249592) have been included in your existing downstream PRs.

Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 703e8fa into GoogleCloudPlatform:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants