[#16607] Fix: support iamMember (i.e. for WIF ids) in big query datasets

[LucaPrete]

Fix: allow users to set permissions for principal/principalSets (iamMember) in BigQuery datasets.

Fixes github.com/hashicorp/terraform-provider-google/issues/16607

bigquery: allowed users to set permissions for `principal`/`principalSets` (`iamMember`) in `google_bigquery_dataset_iam_member`.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 107
Passed tests 99
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages

• bigquery

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[LucaPrete]

Please wait to merge this. Adding tests and fixing a few things.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 77 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 4 files changed, 77 insertions(+), 14 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3424
Passed tests 3070
Skipped tests: 351
Affected tests: 3

Click here to see the affected service packages

all service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigqueryDatasetIamMember_iamMember|TestAccBigqueryDatasetIamMember_serviceAccount|TestAccWorkstationsWorkstationConfig_updateHostDetails

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryDatasetIamMember_serviceAccount[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigqueryDatasetIamMember_iamMember[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_updateHostDetails[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[LucaPrete]

@rileykarson @ScottSuarez this is ready for review on my side but apparently the test here is failing.

I cannot reproduce the error on TestAccBigqueryDatasetIamMember_iamMember, while the other error seems completely unrelated with what I did.

Can you please help me to figure out what's going on?

Thank you!

[tgmof]

Opportunistic refactoring/fix opportunity:
1- projectWriters, projectReaders, projectOwners are not documented as possible output https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/bigquery_dataset_iam#google_bigquery_dataset_iam_member

2- allUsers is documented but doesn't look to be a case handled by the API (?). https://cloud.google.com/bigquery/docs/reference/rest/v2/datasets#Dataset

[tgmof]

Feel free to ignore this comment if not relevant / I lack of context but I just ping you in case you missed this comment @LucaPrete .

[LucaPrete]

Hey, sorry..I missed this. We can certainly work on this in a separate PR.

[c2thorn]

This may be due to an existing bug with google_bigquery_dataset_iam_member: hashicorp/terraform-provider-google#17172

I'll try running again to see if it is consistent

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 77 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 4 files changed, 77 insertions(+), 14 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3424
Passed tests 3071
Skipped tests: 351
Affected tests: 2

Click here to see the affected service packages

all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigqueryDatasetIamMember_iamMember|TestAccWorkstationsWorkstationConfig_updateHostDetails

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigqueryDatasetIamMember_iamMember[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_updateHostDetails[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[LucaPrete]

Hello @c2thorn do we know why this is still failing? We've a p1 open and we'd like to go through the review/merge as soon as we can. Please, let me know if there's anything I can do from my side.

[c2thorn]

@LucaPrete I do not know why it is failing, I believe it is an existing bug as seen in hashicorp/terraform-provider-google#17172

Nothing from the test config for your addition points to a bug that I can see, but I'm not going to be able to merge this yet until we solve it. I won't have time to do a deep debugging dive until late tomorrow.

I can run the test in a different environment to see if it environment-specific if you aren't able to recreate it.

[c2thorn]

Test failed again.

@LucaPrete do you have a debug log of a successful run?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 78 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 4 files changed, 78 insertions(+), 16 deletions(-))
TF Conversion: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))

[LucaPrete]

@c2thorn it should be all fixed now!

[modular-magician]

Tests analytics

Total tests: 3444
Passed tests: 3091
Skipped tests: 351
Affected tests: 2

Click here to see the affected service packages

all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigqueryDatasetIamMember_iamMember|TestAccWorkstationsWorkstationConfig_updateHostDetails

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryDatasetIamMember_iamMember[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_updateHostDetails[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test