[#15779] Adds the google_network_security_security_profile_group resource

[LucaPrete]

Adds the new google_network_security_security_profile_group resource.

fixes hashicorp/terraform-provider-google/issues/15779

Release Note Template for Downstream PRs (will be copied)

networksecurity: new `google_network_security_security_profile_group` resource

[LucaPrete]

@melinath I answered/solved all comments. We should now be good and ready for another round of reviews.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 159 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1027 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 96 insertions(+))

[modular-magician]

Tests analytics

Total tests: 34
Passed tests 33
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[melinath]

A few small things, but overall this seems straightforward and looks good.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 156 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1012 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 96 insertions(+))

[modular-magician]

Tests analytics

Total tests: 35
Passed tests: 33
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkSecuritySecurityProfileGroup_networkSecuritySecurityProfileGroupBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[LucaPrete]

Hello @melinath I'm not able to reproduce the error locally...I'm suspecting a glitch? Maybe I'm not seeing something. Can you please double check? Otherwise, the PR is ready from my side for another round of review :) Thanks!

[melinath]

don't see what caused the failed status - rerunning tests /gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 156 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1012 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 96 insertions(+))

[modular-magician]

Tests analytics

Total tests: 35
Passed tests: 34
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• networksecurity

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[LucaPrete]

don't see what caused the failed status - rerunning tests /gcbrun

Thanks it seems it magically did the trick :)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 156 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1013 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 96 insertions(+))

[modular-magician]

Tests analytics

Total tests: 35
Passed tests: 34
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• networksecurity

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log