Add support for gcsfuse volumes to cloudrun v1 in beta

[bskaplan]

Add support for mounting GCS volumes in Cloud Run v1 Services, in the beta provider.

This is a new feature in Cloud Run. Support is added to cloudrunv2 in #9746

Release Note Template for Downstream PRs (will be copied)

cloudrun: added `template.spec.volumes.csi` field to `google_cloud_run_service` to support mounting Cloud Storage buckets using GCSFuse (beta)

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 22 insertions(+))
Terraform Beta: Diff ( 3 files changed, 261 insertions(+))
TF Conversion: Diff ( 1 file changed, 59 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_service (36 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_service" "primary" {
  template {
    spec {
      volumes {
        csi {
          read_only = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 26
Passed tests 22
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunService_csiVolume

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunService_csiVolume[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[melinath]

overall LGTM - I can't check that the docs match since public docs don't seeem to exist yet. I've noted a few small changes, mostly related to the instructions for handwritten beta tests from https://googlecloudplatform.github.io/magic-modules/develop/test/#add-an-update-test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 22 insertions(+))
Terraform Beta: Diff ( 3 files changed, 264 insertions(+))
TF Conversion: Diff ( 1 file changed, 59 insertions(+))

[modular-magician]

Tests analytics

Total tests: 26
Passed tests 22
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunService_csiVolume

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{The provider crashed while running the VCR tests in RECORDING mode}}$
$\textcolor{red}{\textsf{Please fix it to complete your PR}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 24 insertions(+))
Terraform Beta: Diff ( 3 files changed, 268 insertions(+))
TF Conversion: Diff ( 1 file changed, 59 insertions(+))

[bskaplan]

Ok, my attempt to rebase did not go great. Let me try to untangle this.

[modular-magician]

Tests analytics

Total tests: 26
Passed tests 22
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunService_csiVolume

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunService_csiVolume[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 24 insertions(+))
Terraform Beta: Diff ( 3 files changed, 268 insertions(+))
TF Conversion: Diff ( 1 file changed, 59 insertions(+))

[modular-magician]

Tests analytics

Total tests: 26
Passed tests 23
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• cloudrun

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[bskaplan]

ok, managed to sort it out.

[melinath]

LGTM