-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for content-based load balancing to HealthCheck #971
Add support for content-based load balancing to HealthCheck #971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment :)
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
TF downstream look ok. Cc'ed @rambleraptor to look at the ansible one. |
Ansible looks fine! I'm super confused by the diff for MM though. |
Git's behaviour makes sense here! It's just a little unintuitive, and happened because either change was +- 5 lines. It probably chose this one because it was less characters moving. It sees the text changing, but doesn't know how I made that change.
became
It can represent that as the smallest possible diff with either diff: -a
b
+a
c or +b
a
-b
c |
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
eb00f4e
to
f790a39
Compare
Ha! The diff got a little confused here; the "real" change is to move
response
into all 4 types of HealthCheck by moving it out of the conditional. It was previously only available for TCP & SSL.[all]
[terraform]
Add support for content-based load balancing to google_compute_health_check
[terraform-beta]
[ansible]
[inspec]