Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for content-based load balancing to HealthCheck #971

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Nov 30, 2018

Ha! The diff got a little confused here; the "real" change is to move response into all 4 types of HealthCheck by moving it out of the conditional. It was previously only available for TCP & SSL.


[all]

[terraform]

Add support for content-based load balancing to google_compute_health_check

[terraform-beta]

[ansible]

[inspec]

Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment :)

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#164
depends: hashicorp/terraform-provider-google#2550
depends: modular-magician/ansible#138

@chrisst
Copy link
Contributor

chrisst commented Nov 30, 2018

TF downstream look ok. Cc'ed @rambleraptor to look at the ansible one.

@rambleraptor
Copy link
Contributor

Ansible looks fine! I'm super confused by the diff for MM though.

@rileykarson
Copy link
Member Author

Git's behaviour makes sense here! It's just a little unintuitive, and happened because either change was +- 5 lines. It probably chose this one because it was less characters moving.

It sees the text changing, but doesn't know how I made that change.

a
b
c

became

b
a
c

It can represent that as the smallest possible diff with either diff:

-a
b
+a
c

or

+b
a
-b
c

rileykarson and others added 2 commits November 30, 2018 23:51
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the content-based-health-check branch from eb00f4e to f790a39 Compare November 30, 2018 23:51
@modular-magician modular-magician merged commit 5d31513 into GoogleCloudPlatform:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants