Add dynamicGroupMetadata in cloud_identity_group #9452

sqin2019 · 2023-11-10T22:25:33Z

Add dynamicGroupMetadata in cloud_identity_group

cann't test the change as I don't have a test cloud identity account.

cloudidentity: added support for `dynamic_group_metadata` block to `google_cloud_identity_group` resource

modular-magician · 2023-11-10T22:27:06Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-11-10T22:36:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 436 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 436 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))

modular-magician · 2023-11-10T23:50:42Z

Tests analytics

Total tests: 3226
Passed tests 2895
Skipped tests: 329
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup|TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample

Get to know how VCR tests work

modular-magician · 2023-11-10T23:55:45Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudIdentityGroup[Error message] [Debug log]
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

sqin2019 · 2023-11-11T00:12:49Z

Failed with Error

Error: Error creating Group: googleapi: Error 403: Error(3006): This feature (Dynamic Groups) requires a premium SKU.
        
          with google_cloud_identity_group.cloud_identity_groups_dynamic,
          on terraform_plugin_test.tf line 2, in resource "google_cloud_identity_group" "cloud_identity_groups_dynamic":
           2: resource "google_cloud_identity_group" "cloud_identity_groups_dynamic" {

test account need to be upgrade to cloud identity premium according to @rileykarson

modular-magician · 2023-11-16T03:23:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 436 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 436 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))

modular-magician · 2023-11-16T04:36:54Z

Tests analytics

Total tests: 3231
Passed tests 2898
Skipped tests: 330
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup|TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample|TestAccDataSourceGoogleServiceAccountAccessToken_basic

Get to know how VCR tests work

modular-magician · 2023-11-16T04:43:57Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudIdentityGroup[Error message] [Debug log]
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

slevenick · 2023-11-16T16:07:28Z

mmv1/third_party/terraform/services/cloudidentity/resource_cloud_identity_group_test.go.erb

+    id = "tf-test-my-identity-dynamic-group%{random_suffix}@%{org_domain}"
+  }
+
+  labels = {


Looks like the automatically added dynamic group label is causing problems here. We may need to either add a DiffSuppressFunc for that label, or add it explicitly to the tests

Thanks, added it to the tests.

modular-magician · 2023-11-16T17:43:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 437 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 437 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))

modular-magician · 2023-11-16T18:57:21Z

Tests analytics

Total tests: 3233
Passed tests 2900
Skipped tests: 330
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup|TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample|TestAccDataprocJobIamPolicy

Get to know how VCR tests work

modular-magician · 2023-11-16T19:04:55Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudIdentityGroup[Error message] [Debug log]
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-11-16T20:34:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 442 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 437 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))

modular-magician · 2023-11-16T21:49:47Z

Tests analytics

Total tests: 3233
Passed tests 2901
Skipped tests: 330
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup|TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample

Get to know how VCR tests work

modular-magician · 2023-11-16T21:55:10Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudIdentityGroup[Error message] [Debug log]
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-11-16T23:39:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 429 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 429 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))

modular-magician · 2023-11-17T00:50:36Z

Tests analytics

Total tests: 3233
Passed tests 2902
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample

Get to know how VCR tests work

modular-magician · 2023-11-17T00:51:45Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

slevenick

I'm still seeing this show up in the tests:
~ labels = {
- "cloudidentity.googleapis.com/groups.dynamic" = "" -> null
# (1 unchanged element hidden)
}

Are you able to successfully run the tests?

modular-magician · 2023-11-17T18:24:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 440 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 3 files changed, 443 insertions(+), 17 deletions(-))
TF Conversion: Diff ( 1 file changed, 103 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_identity_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_identity_group" "primary" {
  dynamic_group_metadata {
    queries {
      query         = # value needed
      resource_type = # value needed
    }
  }
}

sqin2019 · 2023-12-09T00:22:01Z

The test failed at group creation, added a diffsuppressfunc instead, workaround to use diffsupressfunc for map.

modular-magician · 2023-12-09T01:17:38Z

$\textcolor{red}{\textsf{The provider crashed while running the VCR tests in REPLAYING mode}}$
$\textcolor{red}{\textsf{Please fix it to complete your PR}}$
View the build log

modular-magician · 2023-12-11T17:50:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 423 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 423 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 131 insertions(+))

modular-magician · 2023-12-11T18:48:54Z

Tests analytics

Total tests: 3280
Passed tests 2941
Skipped tests: 337
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup|TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample

Get to know how VCR tests work

modular-magician · 2023-12-11T19:04:12Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudIdentityGroup[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

slevenick

Continuing to fail due to server-set label

modular-magician · 2023-12-11T23:09:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 423 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 423 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 131 insertions(+))

modular-magician · 2023-12-12T00:09:52Z

Tests analytics

Total tests: 3291
Passed tests 2952
Skipped tests: 337
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

modular-magician · 2023-12-12T00:21:39Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-12T01:00:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 423 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 423 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 131 insertions(+))

modular-magician · 2023-12-12T01:58:14Z

Tests analytics

Total tests: 3291
Passed tests 2952
Skipped tests: 337
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

modular-magician · 2023-12-12T02:05:22Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-12T19:22:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 423 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 423 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 131 insertions(+))

modular-magician · 2023-12-12T20:28:33Z

Tests analytics

Total tests: 3291
Passed tests 2952
Skipped tests: 338
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample

Get to know how VCR tests work

modular-magician · 2023-12-12T20:31:46Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

This reverts commit 90ca9d4.

modular-magician · 2023-12-12T20:48:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 456 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 456 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 131 insertions(+))

modular-magician · 2023-12-12T21:45:31Z

Tests analytics

Total tests: 3293
Passed tests 2954
Skipped tests: 338
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample

Get to know how VCR tests work

modular-magician · 2023-12-12T21:46:46Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudIdentityGroup_cloudIdentityGroupsDynamicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

github-actions · 2024-05-22T09:40:35Z

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

slevenick

Test failing, please fix

github-actions · 2024-06-05T09:40:31Z

@sqin2019, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions · 2024-06-19T09:41:22Z

@sqin2019, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

modular-magician requested a review from slevenick November 10, 2023 22:27

modular-magician added the service/cloudidentity-groups label Nov 10, 2023

sqin2019 marked this pull request as ready for review November 14, 2023 00:46

Add dynamicGroupMetadata in cloud_identity_group

636683e

sqin2019 force-pushed the sqin/dynamic branch from a0eed5e to 636683e Compare November 16, 2023 03:12

slevenick reviewed Nov 16, 2023

View reviewed changes

modular-magician requested a review from slevenick November 16, 2023 17:33

fix dynamic group update

e38f6ae

sqin2019 force-pushed the sqin/dynamic branch from 04dc53b to e38f6ae Compare November 16, 2023 20:23

fix update

a6fc83e

slevenick requested changes Nov 17, 2023

View reviewed changes

modular-magician requested a review from slevenick November 17, 2023 18:13

fix build failure

aa192c5

slevenick reviewed Dec 11, 2023

View reviewed changes

fix supressfunc

7d01137

modular-magician requested a review from slevenick December 11, 2023 22:59

check

40f5fec

ExpectNonEmptyPlan

9bacfd4

Revert "test dynamic group create"

54bd362

This reverts commit 90ca9d4.

slevenick requested changes May 22, 2024

View reviewed changes

BBBmau mentioned this pull request Jun 15, 2024

google_storage_bucket: fix custom_placement_config values not normalized #10936

Merged

sqin2019 closed this Jun 20, 2024

Add dynamicGroupMetadata in cloud_identity_group #9452

Add dynamicGroupMetadata in cloud_identity_group #9452

Conversation

sqin2019 commented Nov 10, 2023

modular-magician commented Nov 10, 2023

modular-magician commented Nov 10, 2023

Diff report

modular-magician commented Nov 10, 2023

Tests analytics

Action taken

modular-magician commented Nov 10, 2023

sqin2019 commented Nov 11, 2023 • edited Loading

modular-magician commented Nov 16, 2023

Diff report

modular-magician commented Nov 16, 2023

Tests analytics

Action taken

modular-magician commented Nov 16, 2023

Rerun these tests in REPLAYING mode to catch issues

slevenick Nov 16, 2023

Choose a reason for hiding this comment

sqin2019 Nov 16, 2023

Choose a reason for hiding this comment

modular-magician commented Nov 16, 2023

Diff report

modular-magician commented Nov 16, 2023

Tests analytics

Action taken

modular-magician commented Nov 16, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Nov 16, 2023

Diff report

modular-magician commented Nov 16, 2023

Tests analytics

Action taken

modular-magician commented Nov 16, 2023

modular-magician commented Nov 16, 2023

Diff report

modular-magician commented Nov 17, 2023

Tests analytics

Action taken

modular-magician commented Nov 17, 2023

slevenick left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 17, 2023

Diff report

Missing test report

sqin2019 commented Dec 9, 2023

modular-magician commented Dec 9, 2023

modular-magician commented Dec 11, 2023

Diff report

modular-magician commented Dec 11, 2023

Tests analytics

Action taken

modular-magician commented Dec 11, 2023

Rerun these tests in REPLAYING mode to catch issues

slevenick left a comment

Choose a reason for hiding this comment

modular-magician commented Dec 11, 2023

Diff report

modular-magician commented Dec 12, 2023

Tests analytics

Action taken

modular-magician commented Dec 12, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 12, 2023

Diff report

modular-magician commented Dec 12, 2023

Tests analytics

Action taken

modular-magician commented Dec 12, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 12, 2023

Diff report

modular-magician commented Dec 12, 2023

Tests analytics

Action taken

modular-magician commented Dec 12, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 12, 2023

sqin2019 commented Nov 11, 2023 •

edited

Loading