Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote labels field on google_compute_vpn_tunnel to GA #9441

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Nov 9, 2023

Fixes hashicorp/terraform-provider-google#16458

TODO:

  • Update acceptance tests to handle labels
  • Look for any issues with effective_labels etc

Release Note Template for Downstream PRs (will be copied)

compute: promoted `labels` field on `google_compute_vpn_tunnel` resource to GA

@SarahFrench SarahFrench marked this pull request as draft November 9, 2023 15:44
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 210 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 3 deletions(-))

@SarahFrench
Copy link
Contributor Author

SarahFrench commented Nov 9, 2023

I've triggered all compute acc tests that contain "Vpn" in their name in this build. There might be some test failures due to labels stuff, and I might need to ignore some labels-related fields in import test steps.

Edit: no test failures, but also the tests won't include the labels field yet

Edit : here's the build running tests again after the commit below

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 218 insertions(+), 89 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 197 deletions(-))
TF OiCS: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3224
Passed tests 2893
Skipped tests: 329
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@SarahFrench SarahFrench marked this pull request as ready for review November 10, 2023 18:29
@SarahFrench SarahFrench requested a review from c2thorn November 10, 2023 18:29
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SarahFrench SarahFrench merged commit e806556 into main Nov 13, 2023
9 checks passed
swamitagupta pushed a commit to swamitagupta/magic-modules that referenced this pull request Nov 14, 2023
…oudPlatform#9441)

* Promote `labels` field on `google_compute_vpn_tunnel` to GA

* Update GA vpn tunnel generated tests to include labels, remove beta-specific tests
trodge pushed a commit to trodge/magic-modules that referenced this pull request Nov 27, 2023
…oudPlatform#9441)

* Promote `labels` field on `google_compute_vpn_tunnel` to GA

* Update GA vpn tunnel generated tests to include labels, remove beta-specific tests
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 28, 2023
…oudPlatform#9441)

* Promote `labels` field on `google_compute_vpn_tunnel` to GA

* Update GA vpn tunnel generated tests to include labels, remove beta-specific tests
jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023
…oudPlatform#9441)

* Promote `labels` field on `google_compute_vpn_tunnel` to GA

* Update GA vpn tunnel generated tests to include labels, remove beta-specific tests
@SarahFrench SarahFrench deleted the promote-vpntunnel-labels-ga branch February 6, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make google_compute_vpn_tunnel.labels available in GA provider
3 participants