-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote labels
field on google_compute_vpn_tunnel
to GA
#9441
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 210 insertions(+), 3 deletions(-)) |
I've triggered all compute acc tests that contain "Vpn" in their name in this build. There might be some test failures due to labels stuff, and I might need to ignore some labels-related fields in import test steps. Edit: no test failures, but also the tests won't include the labels field yet Edit : here's the build running tests again after the commit below |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 218 insertions(+), 89 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oudPlatform#9441) * Promote `labels` field on `google_compute_vpn_tunnel` to GA * Update GA vpn tunnel generated tests to include labels, remove beta-specific tests
…oudPlatform#9441) * Promote `labels` field on `google_compute_vpn_tunnel` to GA * Update GA vpn tunnel generated tests to include labels, remove beta-specific tests
…oudPlatform#9441) * Promote `labels` field on `google_compute_vpn_tunnel` to GA * Update GA vpn tunnel generated tests to include labels, remove beta-specific tests
…oudPlatform#9441) * Promote `labels` field on `google_compute_vpn_tunnel` to GA * Update GA vpn tunnel generated tests to include labels, remove beta-specific tests
Fixes hashicorp/terraform-provider-google#16458
TODO:
Release Note Template for Downstream PRs (will be copied)