add standard type vmwareengine network

[swamitagupta]

Added support for STANDARD type VMwareEngine Network resource and datasource.
Promoted the Network resource from Beta to GA

Release Note Template for Downstream PRs (will be copied)

vmwareengine: added `STANDARD` type support to `google_vmwareengine_network` resource

`google_vmwareengine_network` (ga)

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 928 insertions(+), 44 deletions(-))
Terraform Beta: Diff ( 7 files changed, 30 insertions(+), 221 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3205
Passed tests 2876
Skipped tests: 325
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample|TestAccDataSourceVmwareEngineNetwork_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccLoggingProjectSink_updatePreservesCustomWriter[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample[Error message] [Debug log]
TestAccDataSourceVmwareEngineNetwork_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 928 insertions(+), 44 deletions(-))
Terraform Beta: Diff ( 7 files changed, 30 insertions(+), 221 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3205
Passed tests 2878
Skipped tests: 325
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample|TestAccDataSourceVmwareEngineNetwork_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample[Error message] [Debug log]
TestAccDataSourceVmwareEngineNetwork_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 928 insertions(+), 44 deletions(-))
Terraform Beta: Diff ( 7 files changed, 30 insertions(+), 221 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3224
Passed tests 2893
Skipped tests: 329
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample|TestAccDataSourceVmwareEngineNetwork_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample[Error message] [Debug log]
TestAccDataSourceVmwareEngineNetwork_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

Just noting that I'm waiting for this to exit draft before reviewing! Let me know if you'd like a pass before that.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 983 insertions(+), 41 deletions(-))
Terraform Beta: Diff ( 7 files changed, 34 insertions(+), 167 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3225
Passed tests 2893
Skipped tests: 329
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample|TestAccDataSourceVmwareEngineNetwork_basic|TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample[Error message] [Debug log]
TestAccDataSourceVmwareEngineNetwork_basic[Error message] [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[swamitagupta]

Just noting that I'm waiting for this to exit draft before reviewing! Let me know if you'd like a pass before that.

Hi Riley,
Still finishing up the PR, will exit draft once done to kickoff the review procedure.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 983 insertions(+), 41 deletions(-))
Terraform Beta: Diff ( 7 files changed, 34 insertions(+), 167 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3225
Passed tests 2892
Skipped tests: 329
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample|TestAccDataSourceVmwareEngineNetwork_basic|TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample[Error message] [Debug log]
TestAccDataSourceVmwareEngineNetwork_basic[Error message] [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 1020 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 7 files changed, 39 insertions(+), 103 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3225
Passed tests 2892
Skipped tests: 329
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample|TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate|TestAccDataSourceVmwareEngineNetwork_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample[Error message] [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate[Error message] [Debug log]
TestAccDataSourceVmwareEngineNetwork_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 1020 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 7 files changed, 39 insertions(+), 103 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3226
Passed tests 2893
Skipped tests: 329
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample|TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate|TestAccDataSourceVmwareEngineNetwork_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample[Error message] [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate[Error message] [Debug log]
TestAccDataSourceVmwareEngineNetwork_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 1020 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 7 files changed, 39 insertions(+), 103 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3226
Passed tests 2889
Skipped tests: 329
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAttachedCluster_containerAttachedClusterFullExample|TestAccContainerAttachedCluster_update|TestAccDataprocJobIamPolicy|TestAccDataprocClusterIamPolicy|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample|TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate|TestAccDataSourceVmwareEngineNetwork_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAttachedCluster_containerAttachedClusterFullExample[Debug log]
TestAccContainerAttachedCluster_update[Debug log]
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkStandardExample[Debug log]
TestAccDataSourceVmwareEngineNetwork_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]
TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 1019 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 7 files changed, 39 insertions(+), 104 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3230
Passed tests 2899
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 1019 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 7 files changed, 39 insertions(+), 104 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3230
Passed tests 2899
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

TestAccLoggingProjectSink_updatePreservesCustomWriter doesn't look related, we can ignore it. Changes LGTM- just got a merge conflict to resolve to merge.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 16 files changed, 1018 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 7 files changed, 39 insertions(+), 104 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 16 files changed, 1019 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 7 files changed, 39 insertions(+), 104 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3236
Passed tests 2904
Skipped tests: 330
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocClusterIamPolicy|TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[swamitagupta]

TestAccLoggingProjectSink_updatePreservesCustomWriter doesn't look related, we can ignore it. Changes LGTM- just got a merge conflict to resolve to merge.

Resolved the merge conflict.

[rileykarson]

Note: I deleted the cassettes for TestAccLoggingProjectSink_updatePreservesCustomWriter to ensure we didn't overwrite HEAD w/ them