Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: Stackdriver uptime check #933

Merged
merged 12 commits into from
Nov 28, 2018
Merged

New Resource: Stackdriver uptime check #933

merged 12 commits into from
Nov 28, 2018

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Nov 20, 2018 •
edited
Loading

[all]

New Resource: Stackdriver uptime check

[terraform]

[terraform-beta]

[ansible]

[inspec]

@chrisst chrisst mentioned this pull request Nov 20, 2018
Merged
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#146
depends: hashicorp/terraform-provider-google#2502

@chrisst chrisst changed the title WIP Stackdriver uptime check New Resource: Stackdriver uptime check Nov 20, 2018
@chrisst chrisst requested a review from danawillow November 20, 2018 20:41
@chrisst
Copy link
Contributor Author

chrisst commented Nov 20, 2018

I'll rebase once 934 is in and that will clean up the diff a bunch

@chrisst chrisst force-pushed the stackdriver-uptime-check branch from c4e28c5 to 8055677 Compare November 20, 2018 20:50
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit f90b5bc) have been included in your existing downstream PRs.

danawillow
danawillow reviewed Nov 21, 2018
View reviewed changes
provider/terraform/custom_code.rb Outdated Show resolved Hide resolved
provider/terraform/property_override.rb Outdated Show resolved Hide resolved
templates/terraform/custom_expand/group_name_to_id.erb Outdated Show resolved Hide resolved
templates/terraform/custom_flatten/get_pwd_from_config.erb Outdated Show resolved Hide resolved
templates/terraform/custom_flatten/group_id_to_name.erb
@@ -0,0 +1,4 @@
func flattenMonitoringUptimeCheckConfigResourceGroupGroupId(v interface{}, d *schema.ResourceData) interface{} {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but we should start thinking about doing something about this pattern- there's a few similar flatteners around.

@chrisst chrisst mentioned this pull request Nov 21, 2018
Merged
@chrisst chrisst force-pushed the stackdriver-uptime-check branch from 89874f3 to bd7e01f Compare November 22, 2018 00:07
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 8639fa0) have been included in your existing downstream PRs.

danawillow
danawillow reviewed Nov 26, 2018
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be added to the documentation sidebar.

Can you rename the downstream PRs so they have descriptive titles?

products/monitoring/api.yaml Outdated Show resolved Hide resolved
products/monitoring/api.yaml Outdated Show resolved Hide resolved
products/monitoring/api.yaml Outdated Show resolved Hide resolved
products/monitoring/api.yaml Outdated Show resolved Hide resolved
@chrisst chrisst force-pushed the stackdriver-uptime-check branch from 480c03c to efa23e4 Compare November 26, 2018 21:05
chrisst added 11 commits November 28, 2018 18:45
@chrisst @modular-magician
gce-instance uptime check
d2205b0
@chrisst @modular-magician
Http check auth work arounds
646cfc0 
http check supports basic auth by passing in a username and password. However
the api will return "*****" for password if the password has been set. This
makes it difficult to determine if the password has been changed since the
response is always the same string. As a work around I've set a different
field with the actual content of the password on create and udpate so that it
can be checked against the value in the plan to determine if there are changes
that need to be sent.
@chrisst @modular-magician
Removing the password sentinal
d842d54 
In favor of passing through the resource root in order to bypass the flatten
logic so we can ignore the password value from the api.
@chrisst @modular-magician
working http check tests
31fb93e
@chrisst @modular-magician
cleanup names
79c3337
@chrisst @modular-magician
Get Groups working with uptime checks
d7b431e
@chrisst @modular-magician
Change groupID to resource Ref
734aa61
@chrisst @modular-magician
cleanup todos and force new resource on changing group
ac85480
@chrisst @modular-magician
Code review comments
389d369 
renaming some files and methods to be more specific
removing pre-create custom hook
@chrisst @modular-magician
Add new stackdriver resources to website
f1a7e89
@chrisst @modular-magician
fix formatting and whitespace
d3e57a0
@modular-magician
Update tracked submodules -> HEAD on Wed Nov 28 18:45:13 UTC 2018
462541d 
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 486a8ab into GoogleCloudPlatform:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisst @modular-magician @danawillow @googlebot