Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "check breakage for adding required fields" #9146

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Revert "check breakage for adding required fields" #9146

merged 1 commit into from
Oct 2, 2023

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Oct 2, 2023 •
edited
Loading

Reverts #9126

@ScottSuarez
Copy link
Contributor Author

#9109 (comment)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez merged commit 5a1405f into main Oct 2, 2023
8 of 9 checks passed
@ScottSuarez ScottSuarez deleted the revert-9126-detect-field-added-required branch October 2, 2023 22:42
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 5, 2023
@ScottSuarez @trodge
Revert "check breakage for adding required fields" (GoogleCloudPlatfo…
0c9f583 
…rm#9146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScottSuarez @modular-magician @rileykarson