remove google_identity_platform_project_default_config resource.

[mraouffouad]

Remove google_identity_platform_project_default_config. The resource was deprecated in pr/8559.

Release Note Template for Downstream PRs (will be copied)

Removeing `google_identity_platform_project_default_config`.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_identity_platform_project_default_config was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 2 insertions(+), 1126 deletions(-))
Terraform Beta: Diff ( 4 files changed, 2 insertions(+), 1126 deletions(-))
TF Conversion: Diff ( 1 file changed, 281 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3068
Passed tests 2754
Skipped tests: 307
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccSpannerInstanceIamPolicy|TestAccVertexAIIndexEndpoint_updated

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]
TestAccBigQueryDataTable_bigtable[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[mraouffouad]

@ScottSuarez I'm not sure why the linter is applied to ProjectDefaultConfig.yaml, which is being deleted in this PR.

It'd be great if we can get this change into 5.0.0.

[ScottSuarez]

Hey @mraouffouad, Have you contacted our leads about this? We only accept resource removals in rare cases and only if discussed with our team prior to merge.

[mraouffouad]

Hey @mraouffouad, Have you contacted our leads about this? We only accept resource removals in rare cases and only if discussed with our team prior to merge.

Yes, @shuyama1 and @c2thorn are aware of this change as a follow-up of pr/8559.

[c2thorn]

Discussed offline with the service team and @mraouffouad
We will not remove this resource for now.
Created #9057 to update the upgrade guide
Created hashicorp/terraform-provider-google#15963 to track the future removal.