Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloud iot service #8868

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Sep 5, 2023

Fixes hashicorp/terraform-provider-google#13826

Release Note Template for Downstream PRs (will be copied)

cloudiot: deprecated resource  `google_cloudiot_registry`
cloudiot:  deprecated resource `google_cloudiot_device`
cloudiot: deprecated resource `google_cloudiot_registry_iam_*`
cloudiot:  deprecated datasource `google_cloudiot_registry_iam_policy`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_cloudiot_device was either removed or renamed - reference
  • Resource google_cloudiot_registry_iam_binding was either removed or renamed - reference
  • Resource google_cloudiot_registry_iam_member was either removed or renamed - reference
  • Resource google_cloudiot_registry_iam_policy was either removed or renamed - reference
  • Resource google_cloudiot_registry was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 24 files changed, 3 insertions(+), 4027 deletions(-))
Terraform Beta: Diff ( 24 files changed, 3 insertions(+), 4027 deletions(-))
TF Conversion: Diff ( 5 files changed, 1032 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2992
Passed tests 2690
Skipped tests: 301
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016
Copy link
Member Author

zli82016 commented Sep 5, 2023

Also, the deprecation message is added and 5.0.0 guide is updated in #8870

@zli82016 zli82016 requested review from a team and roaks3 and removed request for a team September 5, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants