Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in managed zone api #881

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Error in managed zone api #881

merged 2 commits into from
Mar 14, 2019

Conversation

rambleraptor
Copy link
Contributor

nameServerSet should be a String, not Array of Strings.


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#129

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason this didn't generate terraform code is because we exclude that field anyway. We can probably add it in now, but that doesn't have to be done in this PR.

@rileykarson
Copy link
Member

@rambleraptor should we update + merge this?

@rambleraptor
Copy link
Contributor Author

rambleraptor commented Mar 13, 2019

Yeah, probably should. I remember Dana + I having a conversation about this creating a TF diff that would require a migration, which is why I avoided merging it.

Is that true?

@rileykarson
Copy link
Member

rileykarson commented Mar 13, 2019

We don't generate the field in Terraform, but if we did generate it, it would have. We're good.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the diff stays the same after rebasing LGTM

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c71f4ad.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#213

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2f60af4.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rambleraptor and others added 2 commits March 14, 2019 18:28
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants