-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in managed zone api #881
Conversation
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason this didn't generate terraform code is because we exclude that field anyway. We can probably add it in now, but that doesn't have to be done in this PR.
@rambleraptor should we update + merge this? |
Yeah, probably should. I remember Dana + I having a conversation about this creating a TF diff that would require a migration, which is why I avoided merging it. Is that true? |
We don't generate the field in Terraform, but if we did generate it, it would have. We're good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the diff stays the same after rebasing LGTM
d174074
to
c71f4ad
Compare
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
c71f4ad
to
2f60af4
Compare
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
2f60af4
to
979451f
Compare
nameServerSet
should be a String, not Array of Strings.[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]