-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TeamCity : Skip google_project
sweeper in Beta projects
#8756
TeamCity : Skip google_project
sweeper in Beta projects
#8756
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just had one thought regarding post-sweeper (if it is an option)
|
||
<% unless version == 'ga' -%> | ||
// Skip the sweeper for project resources in the Beta tests only | ||
param("env.SKIP_PROJECT_SWEEPER", 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is possible using .teamcity files, but we may want to also make sure that both Post-sweepers use SKIP_PROJECT_SWEEPER
. I think the GA tests will usually finish while the Beta tests are still running, so without SKIP_PROJECT_SWEEPER, we could end up with sporadic test failures in the Beta runs.
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Merging this PR but leaving this issue unaddressed as:
|
…dPlatform#8756) * Add `SKIP_PROJECT_SWEEPER` to Beta projects only * Adding log to project sweeper so skip decision is in logs * Make the param an environment variable instead of configuration parameter * Remove log about skipping project sweeper
…dPlatform#8756) * Add `SKIP_PROJECT_SWEEPER` to Beta projects only * Adding log to project sweeper so skip decision is in logs * Make the param an environment variable instead of configuration parameter * Remove log about skipping project sweeper
…dPlatform#8756) * Add `SKIP_PROJECT_SWEEPER` to Beta projects only * Adding log to project sweeper so skip decision is in logs * Make the param an environment variable instead of configuration parameter * Remove log about skipping project sweeper
…dPlatform#8756) * Add `SKIP_PROJECT_SWEEPER` to Beta projects only * Adding log to project sweeper so skip decision is in logs * Make the param an environment variable instead of configuration parameter * Remove log about skipping project sweeper
This PR allows TeamCity projects made from the TPGB repo to include setting the
SKIP_PROJECT_SWEEPER
ENV, while projects for testing the GA provider do not have it set. Any builds within the project will inherit the value set on the project.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)