Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity : Skip google_project sweeper in Beta projects #8756

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Aug 24, 2023

This PR allows TeamCity projects made from the TPGB repo to include setting the SKIP_PROJECT_SWEEPER ENV, while projects for testing the GA provider do not have it set. Any builds within the project will inherit the value set on the project.

If this PR is for Terraform, I acknowledge that I have:

Release Note Template for Downstream PRs (will be copied)


@SarahFrench SarahFrench requested a review from roaks3 August 24, 2023 15:08
@SarahFrench SarahFrench marked this pull request as ready for review August 24, 2023 15:08
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 1 deletion(-))

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had one thought regarding post-sweeper (if it is an option)


<% unless version == 'ga' -%>
// Skip the sweeper for project resources in the Beta tests only
param("env.SKIP_PROJECT_SWEEPER", 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is possible using .teamcity files, but we may want to also make sure that both Post-sweepers use SKIP_PROJECT_SWEEPER. I think the GA tests will usually finish while the Beta tests are still running, so without SKIP_PROJECT_SWEEPER, we could end up with sporadic test failures in the Beta runs.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2987
Passed tests 2690
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@SarahFrench
Copy link
Contributor Author

SarahFrench commented Nov 14, 2023

Merging this PR but leaving this issue unaddressed as:

  • It existed in the old projects
  • The problem is being addressed in design of the next version of the TeamCity config, which should be more easily extended and customised for edge cases like this

@SarahFrench SarahFrench merged commit 184b2f1 into main Nov 14, 2023
davcen pushed a commit to davcen/gcp-magic-modules that referenced this pull request Nov 17, 2023
…dPlatform#8756)

* Add `SKIP_PROJECT_SWEEPER` to Beta projects only

* Adding log to project sweeper so skip decision is in logs

* Make the param an environment variable instead of configuration parameter

* Remove log about skipping project sweeper
trodge pushed a commit to trodge/magic-modules that referenced this pull request Nov 27, 2023
…dPlatform#8756)

* Add `SKIP_PROJECT_SWEEPER` to Beta projects only

* Adding log to project sweeper so skip decision is in logs

* Make the param an environment variable instead of configuration parameter

* Remove log about skipping project sweeper
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 28, 2023
…dPlatform#8756)

* Add `SKIP_PROJECT_SWEEPER` to Beta projects only

* Adding log to project sweeper so skip decision is in logs

* Make the param an environment variable instead of configuration parameter

* Remove log about skipping project sweeper
jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023
…dPlatform#8756)

* Add `SKIP_PROJECT_SWEEPER` to Beta projects only

* Adding log to project sweeper so skip decision is in logs

* Make the param an environment variable instead of configuration parameter

* Remove log about skipping project sweeper
@SarahFrench SarahFrench deleted the teamcity-skip-project-sweeper-in-beta-tests branch March 19, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants