-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the new resource: google_dataform_repository_release_config #8511
feat: add the new resource: google_dataform_repository_release_config #8511
Conversation
Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 247 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample|TestAccContainerAwsNodePool_BetaBasicHandWritten |
Rerun these tests in REPLAYING mode to catch issues
|
name: 'tablePrefix' | ||
description: Optional. The prefix that should be prepended to all table names. | ||
- !ruby/object:Api::Type::Array | ||
name: status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this refer to the "errorStatus"? Is it an output only field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it should be recentScheduledReleaseRecords
I will update it.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 247 insertions(+)) |
Tests analyticsTotal tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, could you fix the lint issues?
Should be removing some trailing spaces.
@hao-nan-li I have fixed the linting issues |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 247 insertions(+)) |
Tests analyticsTotal tests:
|
…GoogleCloudPlatform#8511) * feat: add the new resource: google_dataform_repository_release_config * Fix `recentScheduledReleaseRecords` name * Fix linting
…GoogleCloudPlatform#8511) * feat: add the new resource: google_dataform_repository_release_config * Fix `recentScheduledReleaseRecords` name * Fix linting
…GoogleCloudPlatform#8511) * feat: add the new resource: google_dataform_repository_release_config * Fix `recentScheduledReleaseRecords` name * Fix linting
fix hashicorp/terraform-provider-google#15308
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)