-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gke gcsfuse #7884
Merged
Merged
Gke gcsfuse #7884
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
31b9e30
Adding GCFuse addons attributes in GKE terraform resource.
soumyapani eae3981
Fixing syntax error.
soumyapani cafa96b
Updating go.mud and go.sum files.
soumyapani 19a928a
Moving "gcp_filestore_csi_driver_config" to "ga" block to include it …
soumyapani f2c1020
Update mmv1/third_party/terraform/website/docs/r/container_cluster.ht…
soumyapani f0c6a28
Updating "gcs_fuse_csi_driver_config" location.
soumyapani 9004199
Fixing the error and moving the right gcs_fuse_csi_driver_config attr…
soumyapani 1e3f33c
Fixing spacing.
soumyapani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3920,6 +3920,9 @@ resource "google_container_cluster" "primary" { | |
kalm_config { | ||
enabled = false | ||
} | ||
gcs_fuse_csi_driver_config { | ||
enabled = false | ||
} | ||
<% end -%> | ||
} | ||
} | ||
|
@@ -3981,6 +3984,9 @@ resource "google_container_cluster" "primary" { | |
kalm_config { | ||
enabled = true | ||
} | ||
gcs_fuse_csi_driver_config { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: could we fix the spacing here too please? for both this and |
||
enabled = true | ||
} | ||
<% end -%> | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we fix the spacing on this (and the line above it) please, to be lined up with kalm_config