Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with missing test detection #7783

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Apr 20, 2023

This makes the missing test detector properly read tests containing resources with multiple levels of arrays of nested objects.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@trodge trodge requested a review from zli82016 April 20, 2023 19:21
@trodge trodge mentioned this pull request Apr 20, 2023
5 tasks
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit 20aae6d into GoogleCloudPlatform:main Apr 20, 2023
@trodge trodge deleted the missing-tests branch April 20, 2023 19:59
ravisiddhu pushed a commit to ravisiddhu/magic-modules that referenced this pull request Apr 25, 2023
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants