Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with importing bq capacity commitments #7621

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Apr 4, 2023

Fixes hashicorp/terraform-provider-google#14199

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed the import logic in`google_bigquery_capacity_commitment`

@chrisst chrisst requested a review from a team as a code owner April 4, 2023 18:22
@chrisst chrisst requested review from roaks3 and removed request for a team April 4, 2023 18:22
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 4, 2023
@c2thorn c2thorn requested review from c2thorn and removed request for roaks3 April 4, 2023 18:35
@chrisst chrisst force-pushed the capacity-import-bug branch from 68af0ad to 4b48d81 Compare April 4, 2023 18:37
@modular-magician modular-magician requested a review from c2thorn April 4, 2023 18:38
@c2thorn
Copy link
Member

c2thorn commented Apr 4, 2023

/gcbrun

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 4, 2023
@c2thorn
Copy link
Member

c2thorn commented Apr 5, 2023

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Apr 5, 2023
@chrisst chrisst force-pushed the capacity-import-bug branch from 4b48d81 to e60f3f3 Compare April 5, 2023 02:31
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 5, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 32 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 4 files changed, 32 insertions(+), 16 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 1 file changed, 2 insertions(+))

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 5, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 32 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 4 files changed, 32 insertions(+), 16 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2552
Passed tests 2273
Skipped tests: 275
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigqueryReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccBigqueryReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

All tests passed
View the build log or the debug log for each test

hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 11, 2023
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 12, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_bigquery_capacity_commitment doesn't set location or id correctly during import.
3 participants