-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix certificate_manager_dns_authorization examples to use sweepable names #7510
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 44 insertions(+), 44 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeTargetSslProxy_update|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceDnsManagedZone_basic|TestAccComputeTargetHttpsProxy_certificateMap|TestAccComputeTargetHttpsProxy_update|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccNetworkServicesGateway_update |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
mmv1/third_party/terraform/tests/resource_compute_target_https_proxy_test.go.erb
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 50 insertions(+), 50 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeTargetSslProxy_update|TestAccComputeTargetHttpsProxy_certificateMap|TestAccComputeTargetHttpsProxy_update|TestAccNetworkServicesGateway_update|TestAccDataSourceDnsManagedZone_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ames (GoogleCloudPlatform#7510) * Fix certificate_manager_dns_authorization examples to use sweepable names * Update other resource in proxy tests to be sweepable * Fix test checks
…ames (GoogleCloudPlatform#7510) * Fix certificate_manager_dns_authorization examples to use sweepable names * Update other resource in proxy tests to be sweepable * Fix test checks
…ames (GoogleCloudPlatform#7510) * Fix certificate_manager_dns_authorization examples to use sweepable names * Update other resource in proxy tests to be sweepable * Fix test checks
fixes hashicorp/terraform-provider-google#14066
I've already deleted the leftover resources causing the issue, so this change just attempts to make these resources sweepable. Note that these particular resource need to be deleted in order, so it remains to be seen how this actually behaves in sweeper runs, but this is at least a step in the right direction.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)