Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certificate_manager_dns_authorization examples to use sweepable names #7510

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Mar 22, 2023

fixes hashicorp/terraform-provider-google#14066

I've already deleted the leftover resources causing the issue, so this change just attempts to make these resources sweepable. Note that these particular resource need to be deleted in order, so it remains to be seen how this actually behaves in sweeper runs, but this is at least a step in the right direction.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@roaks3 roaks3 requested a review from a team as a code owner March 22, 2023 15:30
@roaks3 roaks3 requested review from hao-nan-li and removed request for a team March 22, 2023 15:30
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 44 insertions(+), 44 deletions(-))
Terraform Beta: Diff ( 2 files changed, 44 insertions(+), 44 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2521
Passed tests 2250
Skipped tests: 264
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeTargetSslProxy_update|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceDnsManagedZone_basic|TestAccComputeTargetHttpsProxy_certificateMap|TestAccComputeTargetHttpsProxy_update|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccNetworkServicesGateway_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]
TestAccNetworkServicesGateway_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeTargetSslProxy_update[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]
TestAccComputeTargetHttpsProxy_certificateMap[Error message] [Debug log]
TestAccComputeTargetHttpsProxy_update[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 50 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 2 files changed, 50 insertions(+), 50 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2521
Passed tests 2252
Skipped tests: 264
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeTargetSslProxy_update|TestAccComputeTargetHttpsProxy_certificateMap|TestAccComputeTargetHttpsProxy_update|TestAccNetworkServicesGateway_update|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeTargetSslProxy_update[Debug log]
TestAccComputeTargetHttpsProxy_certificateMap[Debug log]
TestAccComputeTargetHttpsProxy_update[Debug log]
TestAccNetworkServicesGateway_update[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roaks3 roaks3 merged commit c59cbca into main Mar 22, 2023
@roaks3 roaks3 deleted the fix-dns-auth-example-to-be-sweepable branch March 22, 2023 21:33
jingcongw pushed a commit to jingcongw/magic-modules-test that referenced this pull request Mar 23, 2023
…ames (GoogleCloudPlatform#7510)

* Fix certificate_manager_dns_authorization examples to use sweepable names

* Update other resource in proxy tests to be sweepable

* Fix test checks
dannawang0221 pushed a commit to dannawang0221/magic-modules that referenced this pull request Mar 24, 2023
…ames (GoogleCloudPlatform#7510)

* Fix certificate_manager_dns_authorization examples to use sweepable names

* Update other resource in proxy tests to be sweepable

* Fix test checks
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…ames (GoogleCloudPlatform#7510)

* Fix certificate_manager_dns_authorization examples to use sweepable names

* Update other resource in proxy tests to be sweepable

* Fix test checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeTarget*Proxy*
3 participants