Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tfv): Fix missing zone in compute instance #7466

Merged
merged 4 commits into from
Mar 22, 2023
Merged

fix(tfv): Fix missing zone in compute instance #7466

merged 4 commits into from
Mar 22, 2023

Conversation

iyabchen
Copy link
Contributor

For compute instance resource, the zone field is not converted.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@iyabchen iyabchen requested a review from a team as a code owner March 16, 2023 16:20
@iyabchen iyabchen requested review from roaks3 and melinath and removed request for a team and roaks3 March 16, 2023 16:20
@iyabchen
Copy link
Contributor Author

/gcbrun

1 similar comment
@melinath
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Validator: Diff ( 2 files changed, 6 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2501
Passed tests 2235
Skipped tests: 263
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComposerEnvironment_withEncryptionConfigComposer2[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@melinath melinath requested review from roaks3 and removed request for melinath March 17, 2023 16:25
@melinath
Copy link
Member

this is the flipside of GoogleCloudPlatform/terraform-google-conversion#816

@roaks3
Copy link
Contributor

roaks3 commented Mar 21, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Validator: Diff ( 2 files changed, 6 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2517
Passed tests 2251
Skipped tests: 263
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceDnsManagedZone_basic|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccNetworkServicesGateway_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]
TestAccNetworkServicesGateway_update[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

roaks3
roaks3 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roaks3 roaks3 self-requested a review March 21, 2023 20:48
roaks3
roaks3 requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I approved that too quickly after only looking at the code and VCR. It looks like there are still errors with the validator tests.

@iyabchen
Copy link
Contributor Author

The log does not tell which test it is failing?

@roaks3
Copy link
Contributor

roaks3 commented Mar 21, 2023

Here's what I'm seeing (in case you don't have access): https://paste.googleplex.com/6671133569974272

@roaks3
Copy link
Contributor

roaks3 commented Mar 22, 2023

/gcbrun

@modular-magician modular-magician requested a review from roaks3 March 22, 2023 00:05
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Validator: Diff ( 5 files changed, 12 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2517
Passed tests 2252
Skipped tests: 263
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesGateway_update|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@iyabchen
Copy link
Contributor Author

/gcbrun

1 similar comment
@roaks3
Copy link
Contributor

roaks3 commented Mar 22, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Validator: Diff ( 6 files changed, 14 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2521
Passed tests 2254
Skipped tests: 264
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccNetworkServicesGateway_update|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccNetworkServicesGateway_update[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@melinath melinath requested review from roaks3 and removed request for roaks3 March 22, 2023 17:28
@iyabchen
Copy link
Contributor Author

/gcbrun

1 similar comment
@roaks3
Copy link
Contributor

roaks3 commented Mar 22, 2023

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Validator: Diff ( 7 files changed, 16 insertions(+), 8 deletions(-))

@iyabchen
Copy link
Contributor Author

The tests finally passed, thanks a lot for rerunning!

roaks3
roaks3 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, all looks good to me now!

@roaks3
Copy link
Contributor

roaks3 commented Mar 22, 2023

Just want to confirm, is this change good to be merged now?

@iyabchen
Copy link
Contributor Author

Yes, as long as the tests pass, there should be no issues to merge.

@roaks3 roaks3 merged commit 2fbe9b8 into GoogleCloudPlatform:main Mar 22, 2023
@modular-magician modular-magician mentioned this pull request Mar 22, 2023
Merged
5 tasks
jingcongw pushed a commit to jingcongw/magic-modules-test that referenced this pull request Mar 23, 2023
@iyabchen
fix(tfv): Fix missing zone in compute instance (GoogleCloudPlatform#7466
8f3b19c 
)

* fix(tfv): Fix missing zone in compute instance

* fix testfile

* fix instance testdata

* fix example_compute_instance
dannawang0221 pushed a commit to dannawang0221/magic-modules that referenced this pull request Mar 24, 2023
@iyabchen @dannawang0221
fix(tfv): Fix missing zone in compute instance (GoogleCloudPlatform#7466
6b2081c 
)

* fix(tfv): Fix missing zone in compute instance

* fix testfile

* fix instance testdata

* fix example_compute_instance
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
@iyabchen @ericayyliu
fix(tfv): Fix missing zone in compute instance (GoogleCloudPlatform#7466
fb8ab8f 
)

* fix(tfv): Fix missing zone in compute instance

* fix testfile

* fix instance testdata

* fix example_compute_instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaks3 roaks3 roaks3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iyabchen @melinath @modular-magician @roaks3