Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccBigQueryDatasetAccess_authorizedRoutine and add note about usage #7319

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix TestAccBigQueryDatasetAccess_authorizedRoutine and add note about usage #7319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mmv1/products/bigquery/api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ objects:
~> **Note:** If this resource is used alongside a `google_bigquery_dataset` resource, the
dataset resource must either have no defined `access` blocks or a `lifecycle` block with
`ignore_changes = [access]` so they don't fight over which accesses should be on the dataset.
Additionally, both resource cannot be modified in the same apply.
references: !ruby/object:Api::Resource::ReferenceLinks
guides:
'Controlling access to datasets': 'https://cloud.google.com/bigquery/docs/dataset-access-controls'
Expand Down
1 change: 0 additions & 1 deletion mmv1/third_party/terraform/tests/resource_bigquery_dataset_access_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,6 @@ resource "google_bigquery_routine" "public" {

resource "google_bigquery_dataset" "private" {
dataset_id = "%{private_dataset}"
description = "This dataset is private"
}

resource "google_bigquery_dataset_access" "authorized_routine" {
Expand Down